[GitHub] richardlawley opened a new issue #3144: Password Reset ignores redundant VR status when saving new password

[GitBox <gi...@apache.org>]

richardlawley opened a new issue #3144: Password Reset ignores redundant VR status when saving new password
URL: https://github.com/apache/cloudstack/issues/3144
 
 
   <!--
   Verify first that your issue/request is not already reported on GitHub.
   Also test if the latest release and master branch are affected too.
   Always add information AFTER of these HTML comments, but no need to delete the comments.
   -->
   
   ##### ISSUE TYPE
   <!-- Pick one below and delete the rest -->
    * Bug Report
   
   ##### COMPONENT NAME
   <!--
   Categorize the issue, e.g. API, VR, VPN, UI, etc.
   -->
   ~~~
   Management Server
   ~~~
   
   ##### CLOUDSTACK VERSION
   <!--
   New line separated list of affected versions, commit ID for issues on master branch.
   -->
   ~~~
   Verified on 4.8 and 4.11.2
   ~~~
   
   ##### CONFIGURATION
   <!--
   Information about the configuration if relevant, e.g. basic network, advanced networking, etc.  N/A otherwise
   -->
   Advanced Network, Redundant Virtual Routers
   
   ##### OS / ENVIRONMENT
   <!--
   Information about the environment if relevant, N/A otherwise
   -->
   n/a
   
   ##### SUMMARY
   <!-- Explain the problem/feature briefly -->
   When you use the password reset feature, the password is always saved to the first running VR, not the master.  The code in VirtualRouterElement.savePassword appears to iterate over the output of routerDao.listByNetworkOnRole, and returns after the first running router.  This has the outcome that password resets don't work if the first VR on a network is backup.
   
   ##### STEPS TO REPRODUCE
   <!--
   For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
   
   For new features, show how the feature would be used.
   -->
   1. Deploy Isolated Network using DefaultIsolatedNetworkOfferingWithSourceNatService
   2. Restart Network with "Make Redundant" ticked, wait for network to complete so that there is one VR as BACKUP and another as MASTER.
   3. Deploy a VM on new network with password-enabled template, Stop it
   4. Ensure second VR (one with highest r-XXX-VM number) is MASTER.  If not, restart the current master and wait for CS status to update.
   5. Issue password reset for VM.
   
   ##### EXPECTED RESULTS
   <!-- What did you expect to happen when running the steps above? -->
   CloudStack should've saved the password to the MASTER VR
   
   ##### ACTUAL RESULTS
   <!-- What actually happened? -->
   CloudStack saved the password to the BACKUP (first) VR.
   
   The problem can be fixed by sorting the list of routers by redundant status, with MASTER first.  If there are no MASTER routers on a redundant network, I would expect the password reset to fail.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services