You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2020/06/03 09:03:37 UTC

[kudu-CR] [tserver] add 'runtime' tag for scanner ttl ms

Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16028


Change subject: [tserver] add 'runtime' tag for scanner_ttl_ms
......................................................................

[tserver] add 'runtime' tag for scanner_ttl_ms

The --scanner_ttl_ms flag has runtime-settable behavior,
this patch simply adds 'runtime' tag so we don't need
to use '--force' when using 'kudu tserver set_flag'.

Change-Id: I91c2a9192f7f80edc3927fe226ddcd1d7be0d78f
---
M src/kudu/tserver/scanners.cc
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/16028/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91c2a9192f7f80edc3927fe226ddcd1d7be0d78f
Gerrit-Change-Number: 16028
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>

[kudu-CR] [tserver] add 'runtime' tag for scanner ttl ms

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16028 )

Change subject: [tserver] add 'runtime' tag for scanner_ttl_ms
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c2a9192f7f80edc3927fe226ddcd1d7be0d78f
Gerrit-Change-Number: 16028
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 03 Jun 2020 18:07:25 +0000
Gerrit-HasComments: No

[kudu-CR] [tserver] add 'runtime' tag for scanner ttl ms

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16028 )

Change subject: [tserver] add 'runtime' tag for scanner_ttl_ms
......................................................................

[tserver] add 'runtime' tag for scanner_ttl_ms

The --scanner_ttl_ms flag has runtime-settable behavior,
this patch simply adds 'runtime' tag so we don't need
to use '--force' when using 'kudu tserver set_flag'.

Change-Id: I91c2a9192f7f80edc3927fe226ddcd1d7be0d78f
Reviewed-on: http://gerrit.cloudera.org:8080/16028
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <40...@qq.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/tserver/scanners.cc
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yingchun Lai: Looks good to me, but someone else must approve
  Todd Lipcon: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I91c2a9192f7f80edc3927fe226ddcd1d7be0d78f
Gerrit-Change-Number: 16028
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] [tserver] add 'runtime' tag for scanner ttl ms

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/16028 )

Change subject: [tserver] add 'runtime' tag for scanner_ttl_ms
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c2a9192f7f80edc3927fe226ddcd1d7be0d78f
Gerrit-Change-Number: 16028
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 03 Jun 2020 15:58:35 +0000
Gerrit-HasComments: No