You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2025/02/26 04:20:44 UTC
[Impala-ASF-CR] IMPALA-13798: Clear of host-level remote scratch dir on shutdown
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22549
Change subject: IMPALA-13798: Clear of host-level remote scratch dir on shutdown
......................................................................
IMPALA-13798: Clear of host-level remote scratch dir on shutdown
IMPALA-13677 introduces cleanup remote scratch files on startup,
and also introduces a host-level directory to do easier cleanup.
An empty host-level directory in remote storage does not use
resources, but it can stay there forever if a host goes offline
permanently. To improve this, this patch removed the
remote host-level temporary directory on shutdown. This helps
prevent too many empty directories left in the remote scratch
path, especially for hosts that never restart.
Changed the flag remote_scratch_cleanup_on_startup to
remote_scratch_cleanup_on_startstop, so that this flag also
controls to cleanup on shutdown as well.
Tests:
Added an e2e testcase
test_scratch_dirs_remote_dir_removal_on_shutdown.
Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
---
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M be/src/service/impala-server.cc
M tests/custom_cluster/test_scratch_disk.py
5 files changed, 57 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/22549/1
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13798: Clear of host-level remote scratch dir on shutdown
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Clear of host-level remote scratch dir on shutdown
......................................................................
Patch Set 2:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-13798: Clear of host-level remote scratch dir on shutdown
Maybe: "Cleanup host-level remote scratch dir on shutdown"
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@9
PS2, Line 9: cleanup
cleanup of
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14
PS2, Line 14: removed
removes
or
adds support for removing
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14
PS2, Line 14: this
this behavior
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14
PS2, Line 14: permanently
or hostname changes.
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@20
PS2, Line 20: remote_scratch_cleanup_on_startstop
nit: remote_scratch_cleanup_on_start_stop
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@21
PS2, Line 21: to
remove "to"
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@21
PS2, Line 21: as well
either remove "also" or "as well" from this sentence.
http://gerrit.cloudera.org:8080/#/c/22549/2/be/src/runtime/tmp-file-mgr.h
File be/src/runtime/tmp-file-mgr.h:
http://gerrit.cloudera.org:8080/#/c/22549/2/be/src/runtime/tmp-file-mgr.h@209
PS2, Line 209: void ClearForShutdown();
Maybe CleanupAtShutdown() is more clear?
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 00:32:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
IMPALA-13677 introduces cleanup of remote scratch files on startup,
and also introduces a host-level directory to do easier cleanup.
An empty host-level directory in remote storage does not use
resources, but it can stay there forever if a host goes offline
permanently or hostname changes. To improve this behavior, this
patch adds support for removing the remote host-level temporary
directory on shutdown. This helps prevent too many empty
directories left in the remote scratch path, especially for hosts
that never restart.
Changed the flag remote_scratch_cleanup_on_startup to
remote_scratch_cleanup_on_start_stop, so that this flag also
controls cleanup on shutdown.
Tests:
Passed exhaustive tests.
Added an e2e testcase
test_scratch_dirs_remote_dir_removal_on_shutdown.
Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Reviewed-on: http://gerrit.cloudera.org:8080/22549
Reviewed-by: Daniel Becker <da...@cloudera.com>
Reviewed-by: Abhishek Rawat <ar...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/tmp-file-mgr-internal.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M be/src/service/impala-server.cc
M tests/custom_cluster/test_scratch_disk.py
6 files changed, 87 insertions(+), 10 deletions(-)
Approvals:
Daniel Becker: Looks good to me, but someone else must approve
Abhishek Rawat: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11535/
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Feb 2025 02:26:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11536/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Feb 2025 02:30:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13798: Clear of host-level remote scratch dir on shutdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Clear of host-level remote scratch dir on shutdown
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18406/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 00:28:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
IMPALA-13677 introduces cleanup of remote scratch files on startup,
and also introduces a host-level directory to do easier cleanup.
An empty host-level directory in remote storage does not use
resources, but it can stay there forever if a host goes offline
permanently or hostname changes. To improve this behavior, this
patch adds support for removing the remote host-level temporary
directory on shutdown. This helps prevent too many empty
directories left in the remote scratch path, especially for hosts
that never restart.
Changed the flag remote_scratch_cleanup_on_startup to
remote_scratch_cleanup_on_start_stop, so that this flag also
controls cleanup on shutdown.
Tests:
Passed exhaustive tests.
Added an e2e testcase
test_scratch_dirs_remote_dir_removal_on_shutdown.
Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
---
M be/src/runtime/tmp-file-mgr-internal.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M be/src/service/impala-server.cc
M tests/custom_cluster/test_scratch_disk.py
6 files changed, 87 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/22549/3
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11535/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 20:25:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 08:57:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
Patch Set 3:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
> Maybe: "Cleanup host-level remote scratch dir on shutdown"
Done
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@9
PS2, Line 9: cleanup
> cleanup of
Done
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14
PS2, Line 14: chan
> this behavior
Done
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14
PS2, Line 14: permanently
> or hostname changes.
Done
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14
PS2, Line 14: ve this
> removes
Done
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@20
PS2, Line 20: Changed the flag remote_scratch_cle
> nit: remote_scratch_cleanup_on_start_stop
Done
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@21
PS2, Line 21: stop, s
> either remove "also" or "as well" from this sentence.
Done
http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@21
PS2, Line 21: ra
> remove "to"
Done
http://gerrit.cloudera.org:8080/#/c/22549/2/be/src/runtime/tmp-file-mgr.h
File be/src/runtime/tmp-file-mgr.h:
http://gerrit.cloudera.org:8080/#/c/22549/2/be/src/runtime/tmp-file-mgr.h@209
PS2, Line 209: void CleanupAtShutdown();
> Maybe CleanupAtShutdown() is more clear?
Done
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 03:48:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13798: Clear of host-level remote scratch dir on shutdown
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Clear of host-level remote scratch dir on shutdown
......................................................................
IMPALA-13798: Clear of host-level remote scratch dir on shutdown
IMPALA-13677 introduces cleanup remote scratch files on startup,
and also introduces a host-level directory to do easier cleanup.
An empty host-level directory in remote storage does not use
resources, but it can stay there forever if a host goes offline
permanently. To improve this, this patch removed the
remote host-level temporary directory on shutdown. This helps
prevent too many empty directories left in the remote scratch
path, especially for hosts that never restart.
Changed the flag remote_scratch_cleanup_on_startup to
remote_scratch_cleanup_on_startstop, so that this flag also
controls to cleanup on shutdown as well.
Tests:
Passed exhaustive tests.
Added an e2e testcase
test_scratch_dirs_remote_dir_removal_on_shutdown.
Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
---
M be/src/runtime/tmp-file-mgr-internal.h
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M be/src/service/impala-server.cc
M tests/custom_cluster/test_scratch_disk.py
6 files changed, 87 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/22549/2
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18408/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 04:13:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
Patch Set 3:
Testcase failures in the release build seem unrelated, as they also occur with an older commit. Submitting for now. Thanks Abhishek and Daniel for the review.
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Feb 2025 19:23:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
Patch Set 3:
Seems hitting unrelated flaky issue IMPALA-11572, trying to rerun
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Feb 2025 02:30:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Feb 2025 07:50:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
Patch Set 3:
Some test cases failed in the release build. Checking
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Feb 2025 14:22:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Cleanup host-level remote scratch dir on shutdown
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 20:18:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13798: Clear of host-level remote scratch dir on shutdown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Clear of host-level remote scratch dir on shutdown
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18381/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 04:47:28 +0000
Gerrit-HasComments: No