You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Venkat Ranganathan <n....@live.com> on 2015/12/18 22:36:05 UTC

Re: Review Request 39267: Review for SQOOP-2596:Precision of varchar/char column cannot be retrieved from teradata database during sqoop import

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39267/#review111276
-----------------------------------------------------------


Looks good.  Can you please change the test class name to something smaller (VarcharPrecisionTest.java or something).   Test classes should either start with Test (for example Test<testcase>.java ) or should end in Test (for example <testcase>Test.java).    The ones starting with Test are automatically executed as part of the ant test target

- Venkat Ranganathan


On Nov. 3, 2015, 3:39 a.m., kopal niranjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39267/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 3:39 a.m.)
> 
> 
> Review request for Sqoop and Venkat Ranganathan.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> when doing sqoop import from teradata database using jdbc teradata driver, following exception comes for varchar columns:
> 15/09/24 01:52:30 INFO hcat.SqoopHCatUtilities: FAILED: ParseException line 3:18 mismatched input ',' expecting ( near 'varchar' in primitive type specification
> 15/09/24 01:52:30 ERROR tool.ImportTool: Encountered IOException running import job: java.io.IOException: HCat exited with status 64
> at org.apache.sqoop.mapreduce.hcat.SqoopHCatUtilities.executeExternalHCatProgram(SqoopHCatUtilities.java:1129)
> at org.apache.sqoop.mapreduce.hcat.SqoopHCatUtilities.launchHCatCli(SqoopHCatUtilities.java:1078)
> at org.apache.sqoop.mapreduce.hcat.SqoopHCatUtilities.createHCatTable(SqoopHCatUtilities.java:625)
> at org.apache.sqoop.mapreduce.hcat.SqoopHCatUtilities.configureHCat(SqoopHCatUtilities.java:340)
> at org.apache.sqoop.mapreduce.hcat.SqoopHCatUtilities.configureImportOutputFormat(SqoopHCatUtilities.java:783)
> at org.apache.sqoop.mapreduce.ImportJobBase.configureOutputFormat(ImportJobBase.java:98)
> at org.apache.sqoop.mapreduce.ImportJobBase.runImport(ImportJobBase.java:259)
> at org.apache.sqoop.manager.SqlManager.importTable(SqlManager.java:692)
> at org.apache.sqoop.tool.ImportTool.importTable(ImportTool.java:497)
> at org.apache.sqoop.tool.ImportTool.run(ImportTool.java:605)
> at org.apache.sqoop.Sqoop.run(Sqoop.java:143)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:179)
> at org.apache.sqoop.Sqoop.runTool(Sqoop.java:218)
> at org.apache.sqoop.Sqoop.runTool(Sqoop.java:227)
> at org.apache.sqoop.Sqoop.main(Sqoop.java:236)
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java b734e05 
>   src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 9d5a9ee 
>   src/test/com/cloudera/sqoop/manager/VarcharOrCharDatatypeImportTestInTeradata.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39267/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> kopal niranjan
> 
>