You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by zhangh43 <gi...@git.apache.org> on 2016/03/29 04:20:18 UTC
[GitHub] incubator-hawq pull request: HAWQ-601. Clear external table code.
GitHub user zhangh43 opened a pull request:
https://github.com/apache/incubator-hawq/pull/525
HAWQ-601. Clear external table code.
clear unuseful code in external table and treat pxf bucket number as forced vsegs in resource negotiator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangh43/incubator-hawq hawq601
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/525.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #525
----
commit 721fe6847d58a627993cce5fdf621c2fad80269b
Author: hzhang2 <zh...@163.com>
Date: 2016-03-29T02:14:38Z
HAWQ-601. Clear external table code.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-601. Clear external table code.
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-601. Clear external table code.
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/525#discussion_r57666446
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -768,12 +769,23 @@ static void check_keep_hash_and_external_table(
* whose default value is set to default_segment_num
*/
ExtTableEntry* extEnrty = GetExtTableEntry(rel->rd_id);
- if(extEnrty->command){
- // command external table case
- if (context->externTableOnClauseSegNum == 0) {
- context->externTableOnClauseSegNum = targetPolicy->bucketnum;
+
+ bool isPxf = false;
+ if(!extEnrty->command && extEnrty->locations){
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-601. Clear external table code.
Posted by hornn <gi...@git.apache.org>.
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/525#discussion_r57665601
--- Diff: src/backend/cdb/cdbdatalocality.c ---
@@ -768,12 +769,23 @@ static void check_keep_hash_and_external_table(
* whose default value is set to default_segment_num
*/
ExtTableEntry* extEnrty = GetExtTableEntry(rel->rd_id);
- if(extEnrty->command){
- // command external table case
- if (context->externTableOnClauseSegNum == 0) {
- context->externTableOnClauseSegNum = targetPolicy->bucketnum;
+
+ bool isPxf = false;
+ if(!extEnrty->command && extEnrty->locations){
--- End diff --
missing spaces after `if` and before `{`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---