You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/07/24 19:34:01 UTC

[GitHub] [nifi] mgaido91 commented on a change in pull request #3600: NIFI-6420 Controller Service references not properly tracked if multiple references from same component

mgaido91 commented on a change in pull request #3600: NIFI-6420 Controller Service references not properly tracked if multiple references from same component
URL: https://github.com/apache/nifi/pull/3600#discussion_r306973345
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/service/ControllerServiceNode.java
 ##########
 @@ -119,14 +119,16 @@
     /**
      * Indicates that the given component is now referencing this Controller Service
      * @param referringComponent the component referencing this service
+     * @param propertyName is the name of the property for which the component is referencing this controller service
      */
-    void addReference(ComponentNode referringComponent);
+    void addReference(ComponentNode referringComponent, String propertyName);
 
 Review comment:
   what about using the `PropertyDescriptor` instead of its name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services