You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jason810496 (via GitHub)" <gi...@apache.org> on 2026/06/04 03:24:42 UTC

[PR] Fix Java-SDK e2e test registration [airflow]

jason810496 opened a new pull request, #67993:
URL: https://github.com/apache/airflow/pull/67993

   
   ### Why
   
   While working on https://github.com/apache/airflow/pull/67956, I found that we didn't register the Java-SDK correctly.
   
   ### What
   
   Follow the pattern in https://github.com/apache/airflow/pull/67956/commits/fb79b997ec314e4f2633f91994db76d2c7c21c3d (we should update selective check) to register the e2e test correctly.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes (please specify the tool below) With help of Claude Code Opus 4.8 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix Java-SDK e2e test registration [airflow]

Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #67993:
URL: https://github.com/apache/airflow/pull/67993#discussion_r3353342679


##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -214,6 +215,13 @@ def __hash__(self):
             r"^providers/apache/kafka/.*",
             r"^providers/common/messaging/.*",
         ],
+        FileGroupForCi.JAVA_SDK_E2E_FILES: [
+            r"^java-sdk/.*",
+            r"^airflow-e2e-tests/tests/airflow_e2e_tests/java_sdk_tests/.*",
+            r"^airflow-e2e-tests/docker/java\.yml$",
+            r"^airflow-e2e-tests/docker/Dockerfile\.java$",
+            r"^task-sdk/src/airflow/sdk/coordinators/java/.*",
+        ],

Review Comment:
   
   The Go-SDK e2e test patch following the same pattern works (https://github.com/apache/airflow/actions/runs/26927752705/job/79445232931?pr=67956). 
   The Java-SDK e2e test didn't be triggered in this PR as the files we changed are not included in the regex here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix Java-SDK e2e test registration [airflow]

Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #67993:
URL: https://github.com/apache/airflow/pull/67993#discussion_r3353342679


##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -214,6 +215,13 @@ def __hash__(self):
             r"^providers/apache/kafka/.*",
             r"^providers/common/messaging/.*",
         ],
+        FileGroupForCi.JAVA_SDK_E2E_FILES: [
+            r"^java-sdk/.*",
+            r"^airflow-e2e-tests/tests/airflow_e2e_tests/java_sdk_tests/.*",
+            r"^airflow-e2e-tests/docker/java\.yml$",
+            r"^airflow-e2e-tests/docker/Dockerfile\.java$",
+            r"^task-sdk/src/airflow/sdk/coordinators/java/.*",
+        ],

Review Comment:
   
   The Go-SDK patch works (https://github.com/apache/airflow/actions/runs/26927752705/job/79445232931?pr=67956). 
   The Java-SDK e2e test didn't be triggered in this PR as the files we changed are not included in the regex here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix Java-SDK e2e test registration [airflow]

Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 merged PR #67993:
URL: https://github.com/apache/airflow/pull/67993


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix Java-SDK e2e test registration [airflow]

Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv commented on code in PR #67993:
URL: https://github.com/apache/airflow/pull/67993#discussion_r3355349737


##########
dev/breeze/tests/test_selective_checks.py:
##########
@@ -1332,6 +1332,32 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], stderr: str):
             {"run-go-sdk-tests": "true"},
             id="Run go tests for go-sdk",
         ),
+        pytest.param(

Review Comment:
   nit: can you add a negative case asserting a non-Java change leaves run-java-sdk-e2e-tests false?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org