You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/26 01:22:45 UTC
[GitHub] [flink] hequn8128 commented on a change in pull request #10195:
[FLINK-13995][legal] Properly exclude netty license directory
hequn8128 commented on a change in pull request #10195: [FLINK-13995][legal] Properly exclude netty license directory
URL: https://github.com/apache/flink/pull/10195#discussion_r350503350
##########
File path: flink-connectors/flink-connector-elasticsearch2/pom.xml
##########
@@ -212,7 +212,7 @@ under the License.
<excludes>
<!-- Only some of these licenses actually apply to the JAR and have been manually
placed in this module's resources directory. -->
- <exclude>META-INF/license</exclude>
+ <exclude>META-INF/license/**</exclude>
Review comment:
I find that even we remove this exclude, the license folder of netty will not be packaged in the jar. Still, I can't figure out why.
I also create a simple test project to verify this. In my test project, the license folder of netty will be packaged into the jar if we remote the exclude.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services