You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Vladimir Sitnikov <si...@gmail.com> on 2018/08/31 21:04:06 UTC

Re: Test class and package name conventions

Julian>Add the test class to the annotation in CalciteSuite.java

Just wondering: what is the purpose of CalciteSuite at all?
It happens that a new test is not added to CalciteSuite, and it is
invisible to CI.
The test does not get executed, and everybody just assumes the test is fine.

Could we drop CalciteSuite, and just use **Test.java for execution?

Vladimir

Re: Test class and package name conventions

Posted by Julian Hyde <jh...@apache.org>.
It seems easier to run all of the tests in a debugger if they are organized into a suite.

Also, in the suite they are ordered. The quick ones that are more likely to fail are towards the front of the list.

It is true that people forget to add tests to CalciteSuite sometimes.

> On Aug 31, 2018, at 2:04 PM, Vladimir Sitnikov <si...@gmail.com> wrote:
> 
> Julian>Add the test class to the annotation in CalciteSuite.java
> 
> Just wondering: what is the purpose of CalciteSuite at all?
> It happens that a new test is not added to CalciteSuite, and it is
> invisible to CI.
> The test does not get executed, and everybody just assumes the test is fine.
> 
> Could we drop CalciteSuite, and just use **Test.java for execution?
> 
> Vladimir