You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2022/02/03 13:24:41 UTC

[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #498: Improved: WorkEffort - MainActionMenu (OFBIZ-12557)

PierreSmits opened a new pull request #498:
URL: https://github.com/apache/ofbiz-framework/pull/498


   Currently the create buttons for the main objects of the work effort  are located within the find and other widgets/templates of those objects.
   In order to improve the usability of OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the component.
   
   modified:
   WorkEffortMenus.xml - added MainActionMenu for users with CREATE permission in the component
   CommonScreens.xml - added MainActionMenu as an 'include-menu' ref in various common decorator screens.
   Added MainActionMenu as an 'include-menu' in screen definitions in various other Screen.xml files where appropriate
   additional cleanup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [GitHub] [ofbiz-framework] mbrohl commented on pull request #498: Improved: WorkEffort - MainActionMenu (OFBIZ-12557)

Posted by Pierre Smits <pi...@apache.org>.

Indeed, Michael. That was what you said  in comments regarding:

   1. https://github.com/apache/ofbiz-framework/pull/481
   2. https://github.com/apache/ofbiz-framework/pull/482
   3. https://github.com/apache/ofbiz-framework/pull/483

and now again in https://github.com/apache/ofbiz-framework/pull/498

What is this RULE of yours that fellow volunteering contributors MUST
comply with in order to have their improvements go into the codebase:

Is

it

single

line

spacing,

*or*

Is

ig

double

line

spacing?

It must surely feel very frustrating and annoying (even maybe painful?)
when YOU look at code in the OFBiz repositories and the majority of that
code not having the single or double line spacing that you want.
How unfortunate that all those contributors of code improvements over the
past 15 years of this project's existence (including you, contributing for
as long as that, as your claimed elsewhere) violated that RULE of yours
(that you brought forward just 11 days ago).

If the code of OFBiz (and improvements thereon) give you so much
difficulties to read, maybe there are some helpful tools available for you
to continue to bring your valuable contributions to improve this project
and its works? Or maybe it is time to call it quits?

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006
*Apache Directory <https://directory.apache.org>, PMC Member*

Anyone could have been you, whereas I've always been anyone.

On Thu, Feb 3, 2022 at 8:12 PM GitBox <gi...@apache.org> wrote:

>
> mbrohl commented on pull request #498:
> URL:
> https://github.com/apache/ofbiz-framework/pull/498#issuecomment-1029313372
>
>
>    As said before, the removal of blank lines between sections makes the
> files harder to read.
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>

[GitHub] [ofbiz-framework] mbrohl commented on pull request #498: Improved: WorkEffort - MainActionMenu (OFBIZ-12557)

Posted by GitBox <gi...@apache.org>.

mbrohl commented on pull request #498:
URL: https://github.com/apache/ofbiz-framework/pull/498#issuecomment-1029313372


   As said before, the removal of blank lines between sections makes the files harder to read.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #498: Improved: WorkEffort - MainActionMenu (OFBIZ-12557)

Posted by GitBox <gi...@apache.org>.

sonarcloud[bot] commented on pull request #498:
URL: https://github.com/apache/ofbiz-framework/pull/498#issuecomment-1028989712


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=498&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=498) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=498&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=498&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org