[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9145: [dashboard] use filter_scopes metadata when import old dashboard

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #9145: [dashboard] use filter_scopes metadata when import old dashboard
URL: https://github.com/apache/incubator-superset/pull/9145#discussion_r380988352
 
 

 ##########
 File path: superset/models/helpers.py
 ##########
 @@ -278,6 +278,12 @@ def alter_params(self, **kwargs):
         d.update(kwargs)
         self.params = json.dumps(d)
 
+    def remove_params(self, param_to_remove: str, **kwargs: Dict) -> None:
 
 Review comment:
   add typing. is it looks better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org