[jira] Commented: (CASSANDRA-58) Encapsulate Partitioner logic

["Jun Rao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696278#action_12696278 ] 

Jun Rao commented on CASSANDRA-58:
----------------------------------

Just applied patch 0001. A couple of issues.
1. The build file now picks up conf/log4j.properties. However, the log directory points to /var and will fail for regular users. It's probably better to use test/conf during test and set the log directory to some place under build.

2. I got a bunch of stuff like below when running ant test. This looks like the result of compiling the test code in debug mode. Is that what we want?
[testng] DEBUG - DISK TIME: 0 ms.
[testng] DEBUG - MEMTABLE TASKS : 0
[testng] DEBUG - MEMTABLE TASKS : 0
[testng] DEBUG - MEMTABLE TASKS : 0

> Encapsulate Partitioner logic
> -----------------------------
>
>                 Key: CASSANDRA-58
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-58
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>         Attachments: 0001-include-conf-on-classpath-during-testing-so-log4j.p.patch, 0002-consolidate-partition-behavior-in-IPartitioner-so-c.patch
>
>
> the codebase is littered with if statements like this
>             PartitionerType pType = StorageService.getPartitionerType();
>             switch( pType )
>             {
>                 case OPHF:
>                     // code for order-preserving hash
>                     break;
>                     
>                 default:
>                     // code for random hash
>                     break;
>             }
> We want to move all of those if statements into Partitioner methods to make maintenance easier and to better ensure correctness.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.