You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2023/03/15 11:30:47 UTC
[GitHub] [incubator-uniffle] slfan1989 opened a new pull request, #726: [#625] Package sun.security.krb5 is not visible in Java 11 and 17.
slfan1989 opened a new pull request, #726:
URL: https://github.com/apache/incubator-uniffle/pull/726
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Try remove `sun.security.krb5.Config.refresh();`
### Why are the changes needed?
`sun.security.krb5` is not visible in Java 11 and 17. We need to compile on JDK11 and JDK17
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #726: [#625] improvement: Package sun.security.krb5 is not visible in Java 11 and 17.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #726:
URL: https://github.com/apache/incubator-uniffle/pull/726#issuecomment-1469963938
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/726?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#726](https://codecov.io/gh/apache/incubator-uniffle/pull/726?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2dcd0f) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/e38d79952732483756249859aa3a7061233644e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e38d799) will **increase** coverage by `2.28%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #726 +/- ##
============================================
+ Coverage 60.60% 62.88% +2.28%
- Complexity 1849 1858 +9
============================================
Files 229 217 -12
Lines 12749 10897 -1852
Branches 1064 1073 +9
============================================
- Hits 7727 6853 -874
+ Misses 4611 3688 -923
+ Partials 411 356 -55
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...uniffle/common/security/HadoopSecurityContext.java](https://codecov.io/gh/apache/incubator-uniffle/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9zZWN1cml0eS9IYWRvb3BTZWN1cml0eUNvbnRleHQuamF2YQ==) | `81.08% <ø> (-0.50%)` | :arrow_down: |
... and [18 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/726/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] slfan1989 commented on pull request #726: [#625] improvement: Package sun.security.krb5 is not visible in Java 11 and 17.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #726:
URL: https://github.com/apache/incubator-uniffle/pull/726#issuecomment-1471185156
@jerqi @zuston @kaijchen Thank you very much for helping to review the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #726: [#625] improvement: Package sun.security.krb5 is not visible in Java 11 and 17.
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #726:
URL: https://github.com/apache/incubator-uniffle/pull/726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org