You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/07 17:39:47 UTC
[GitHub] [airflow] nhojjohn opened a new pull request, #24301: Fix langauge override in papermill operator
nhojjohn opened a new pull request, #24301:
URL: https://github.com/apache/airflow/pull/24301
This fixes an issue I introduced in https://github.com/apache/airflow/pull/23916 which results in the additional feature introduced in this PR not working.
execute_notebook() expects an argument called language rather than language_name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24301: Fix langauge override in papermill operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24301:
URL: https://github.com/apache/airflow/pull/24301#issuecomment-1149121585
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24301: Fix langauge override in papermill operator
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24301:
URL: https://github.com/apache/airflow/pull/24301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #24301: Fix langauge override in papermill operator
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #24301:
URL: https://github.com/apache/airflow/pull/24301#issuecomment-1149012199
You will need also to fix `language_name` in the tests https://github.com/apache/airflow/blob/main/tests/providers/papermill/operators/test_papermill.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24301: Fix langauge override in papermill operator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24301:
URL: https://github.com/apache/airflow/pull/24301#issuecomment-1149128176
> You will need also to fix `language_name` in the tests https://github.com/apache/airflow/blob/main/tests/providers/papermill/operators/test_papermill.py
I added a fixup-> this way I can release today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org