Re: [PR] HDDS-13982. OmKeyInfo fileName possible inconsistency between cache and DB [ozone]

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on code in PR #9381:
URL: https://github.com/apache/ozone/pull/9381#discussion_r2564908772


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java:
##########
@@ -208,7 +208,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, Execut
             .build();
         openKeyToDelete.setModificationTime(Time.now());
         OMFileRequest.addOpenFileTableCacheEntry(omMetadataManager,
-            dbOpenKeyToDeleteKey, openKeyToDelete, keyName, fileName, trxnLogIndex);
+            dbOpenKeyToDeleteKey, openKeyToDelete, fileName, trxnLogIndex);

Review Comment:
   @ChenSammi I believe this is a bug in hsync: order of `keyName` and `fileName` is mixed up.
   
   Parameters:
   
   https://github.com/apache/ozone/blob/40304b69ae5300b606ed66c97f07cf3a2e2fdc84/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java#L469-L471
   
   Arguments:
   
   https://github.com/apache/ozone/blob/40304b69ae5300b606ed66c97f07cf3a2e2fdc84/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java#L210-L211
   
   Should we be passing `keyName` instead of `fileName`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org