You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by ng...@apache.org on 2011/05/28 22:28:25 UTC

svn commit: r1128769 - in /mina/ftpserver/branches/1.0.x/core/src: main/java/org/apache/ftpserver/command/impl/STAT.java test/java/org/apache/ftpserver/clienttests/StatTest.java

Author: ngn
Date: Sat May 28 20:28:24 2011
New Revision: 1128769

URL: http://svn.apache.org/viewvc?rev=1128769&view=rev
Log:
Returning 211 rather than 200 from STAT file listing (FTPSERVER-413)

Modified:
    mina/ftpserver/branches/1.0.x/core/src/main/java/org/apache/ftpserver/command/impl/STAT.java
    mina/ftpserver/branches/1.0.x/core/src/test/java/org/apache/ftpserver/clienttests/StatTest.java

Modified: mina/ftpserver/branches/1.0.x/core/src/main/java/org/apache/ftpserver/command/impl/STAT.java
URL: http://svn.apache.org/viewvc/mina/ftpserver/branches/1.0.x/core/src/main/java/org/apache/ftpserver/command/impl/STAT.java?rev=1128769&r1=1128768&r2=1128769&view=diff
==============================================================================
--- mina/ftpserver/branches/1.0.x/core/src/main/java/org/apache/ftpserver/command/impl/STAT.java (original)
+++ mina/ftpserver/branches/1.0.x/core/src/main/java/org/apache/ftpserver/command/impl/STAT.java Sat May 28 20:28:24 2011
@@ -80,7 +80,7 @@ public class STAT extends AbstractComman
 
                 session
                 .write(new DefaultFtpReply(
-                                FtpReply.REPLY_200_COMMAND_OKAY,
+                                FtpReply.REPLY_211_SYSTEM_STATUS_REPLY,
                                 dirList));
 
             } catch (FtpException e) {

Modified: mina/ftpserver/branches/1.0.x/core/src/test/java/org/apache/ftpserver/clienttests/StatTest.java
URL: http://svn.apache.org/viewvc/mina/ftpserver/branches/1.0.x/core/src/test/java/org/apache/ftpserver/clienttests/StatTest.java?rev=1128769&r1=1128768&r2=1128769&view=diff
==============================================================================
--- mina/ftpserver/branches/1.0.x/core/src/test/java/org/apache/ftpserver/clienttests/StatTest.java (original)
+++ mina/ftpserver/branches/1.0.x/core/src/test/java/org/apache/ftpserver/clienttests/StatTest.java Sat May 28 20:28:24 2011
@@ -30,7 +30,7 @@ import java.util.regex.Pattern;
 */
 public class StatTest extends ClientTestTemplate {
 
-    private static final String PATTERN = "^200[-\\s]-rw-------\\s\\s\\s1\\suser\\sgroup\\s{12}0\\s[A-Za-z0-9\\s]{6}\\s\\d\\d:\\d\\d\\stest\\d.txt$";
+    private static final String PATTERN = "^211[-\\s]-rw-------\\s\\s\\s1\\suser\\sgroup\\s{12}0\\s[A-Za-z0-9\\s]{6}\\s\\d\\d:\\d\\d\\stest\\d.txt$";
     
     private static final File TEST_DIR = new File(ROOT_DIR, "test");
     private static final File TEST_FILE1 = new File(TEST_DIR, "test1.txt");
@@ -43,7 +43,7 @@ public class StatTest extends ClientTest
         
         client.login(ADMIN_USERNAME, ADMIN_PASSWORD);
 
-        assertEquals(200, client.stat(TEST_DIR.getName()));
+        assertEquals(211, client.stat(TEST_DIR.getName()));
         String[] reply = client.getReplyString().split("\r\n");
 
         assertTrue(reply[0], Pattern.matches(PATTERN, reply[0]));
@@ -56,7 +56,7 @@ public class StatTest extends ClientTest
         
         client.login(ADMIN_USERNAME, ADMIN_PASSWORD);
 
-        assertEquals(200, client.stat(TEST_DIR.getName() + "/" + TEST_FILE1.getName()));
+        assertEquals(211, client.stat(TEST_DIR.getName() + "/" + TEST_FILE1.getName()));
         String[] reply = client.getReplyString().split("\r\n");
 
         assertTrue(reply[0], Pattern.matches(PATTERN, reply[0]));