You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Hiranya Jayathilaka (JIRA)" <ji...@apache.org> on 2013/07/13 09:01:52 UTC
[jira] [Commented] (SYNAPSE-935) PassThrough Transport bug fixes-1
[ https://issues.apache.org/jira/browse/SYNAPSE-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707677#comment-13707677 ]
Hiranya Jayathilaka commented on SYNAPSE-935:
---------------------------------------------
I haven't done a proper review of this patch yet. But at a first glance, I came across the following method:
private static boolean isOneWay(String mepString) {
+ return (mepString.equals(WSDL2Constants.MEP_URI_IN_ONLY) ||
+ mepString.equals(WSDL2Constants.MEP_URI_IN_ONLY) || mepString.equals(WSDL2Constants.MEP_URI_IN_ONLY));
+ }
This was in the SYNAPSE-920 patch as well. I fixed it as follows when committing:
private static boolean isOneWay(String mepString) {
return mepString.equals(WSDL2Constants.MEP_URI_IN_ONLY);
}
Is this the correct implementation? Or should we also compare mepString with a constant from WSDLConstants?
> PassThrough Transport bug fixes-1
> ---------------------------------
>
> Key: SYNAPSE-935
> URL: https://issues.apache.org/jira/browse/SYNAPSE-935
> Project: Synapse
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1
> Reporter: Dushan Sachinda Abeyruwan
> Assignee: Hiranya Jayathilaka
> Priority: Blocker
> Labels: core
> Fix For: FUTURE
>
> Attachments: passthrough_fix_patch_1.txt
>
>
> Hi
> Please find the patch file which contains fixes for following scenario.
> 1. Property mediator to be content aware based the given scope definition.
> 2. Fixed bugs when working with binary messages in RelayUtils.
> 3. BufferFacory re-factored (adding buffer cleanup operation), found the shared buffer not cleanup properly due to high load tests thus,it causes run time exceptions.
> 4. Fix for CHUNKING_DISABLE for lager messages (tested messages such as 100k)
> Did run integration test after applying the patch attached herewith and seems all integration test have passed successfully.
>
> Meantime there are some fixes I have done for content switching issues and some fixes for RESTful services invocation, will provide those patches in different jira.
> Thanks
> Dushan
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org