You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/10/06 09:21:23 UTC
[GitHub] [mynewt-nimble] bvdberg opened a new pull request, #1390: Fix missing includes and missing return (compiler gives error)
bvdberg opened a new pull request, #1390:
URL: https://github.com/apache/mynewt-nimble/pull/1390
This fixes the build after the recent HCI_IPC changes.
Also these changes now add a dependency from Mynewt/drivers/ipc5430 to the Nimble stack, which IMHO is a no go. This is not fixes in this request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a diff in pull request #1390: Fix missing includes and missing return (compiler gives error)
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on code in PR #1390:
URL: https://github.com/apache/mynewt-nimble/pull/1390#discussion_r988813557
##########
nimble/transport/nrf5340/src/nrf5340_ble_hci.c:
##########
@@ -19,11 +19,13 @@
#include <assert.h>
#include <string.h>
+#include <syscfg/syscfg.h>
#include <sysinit/sysinit.h>
#include <nimble/ble.h>
#include <ipc_nrf5340/ipc_nrf5340.h>
#include <nimble/transport.h>
#include <nimble/transport/hci_ipc.h>
+#include <nimble/transport/transport_ipc.h>
Review Comment:
this is included from nimble/transport if hci_ipc package is included in build and it should be, because it's added as dependency to nrf5340 transport package - you likely do not have recent newt which generates required defines in syscfg.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1390: Fix missing includes and missing return (compiler gives error)
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1390:
URL: https://github.com/apache/mynewt-nimble/pull/1390#issuecomment-1269704693
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1390: Fix missing includes and missing return (compiler gives error)
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1390:
URL: https://github.com/apache/mynewt-nimble/pull/1390#issuecomment-1269666514
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc merged pull request #1390: Fix missing includes and missing return (compiler gives error)
Posted by GitBox <gi...@apache.org>.
sjanc merged PR #1390:
URL: https://github.com/apache/mynewt-nimble/pull/1390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on pull request #1390: Fix missing includes and missing return (compiler gives error)
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on PR #1390:
URL: https://github.com/apache/mynewt-nimble/pull/1390#issuecomment-1269701699
> Also these changes now add a dependency from Mynewt/drivers/ipc5430 to the Nimble stack, which IMHO is a no go. This is not fixes in this request.
dependency is to add nimble package which only has generic defs, it does not add dependency to host or controller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] bvdberg commented on pull request #1390: Fix missing includes and missing return (compiler gives error)
Posted by GitBox <gi...@apache.org>.
bvdberg commented on PR #1390:
URL: https://github.com/apache/mynewt-nimble/pull/1390#issuecomment-1269701959
We use FreeRTOS and dont use the Newt build sysetm. I have removed the include. The build also works without.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org