[GitHub] [iceberg] JingsongLi commented on a change in pull request #1517: Flink: apply row-level delete when reading

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #1517:
URL: https://github.com/apache/iceberg/pull/1517#discussion_r495698925



##########
File path: flink/src/main/java/org/apache/iceberg/flink/source/RowDataIterator.java
##########
@@ -92,12 +102,12 @@
     return iter;
   }
 
-  private CloseableIterable<RowData> newAvroIterable(FileScanTask task, Map<Integer, ?> idToConstant) {
+  private CloseableIterable<RowData> newAvroIterable(FileScanTask task, Schema schema, Map<Integer, ?> idToConstant) {
     Avro.ReadBuilder builder = Avro.read(getInputFile(task))
-        .reuseContainers()
-        .project(projectedSchema)
+        .reuseContainers(false)

Review comment:
       The `inputformat.nexRecord` returns reused record, it is OK in Flink.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org