You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/17 23:37:59 UTC
[GitHub] [tvm] driazati opened a new pull request, #11349: [wip][ci] Use S3 for artifacts
driazati opened a new pull request, #11349:
URL: https://github.com/apache/tvm/pull/11349
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #11349: [ci] Use S3 for artifacts
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #11349:
URL: https://github.com/apache/tvm/pull/11349#discussion_r877531330
##########
jenkins/macros.j2:
##########
@@ -89,3 +89,33 @@
}
},
{% endmacro %}
+
+{% macro upload_artifacts(tag, filenames, folders=[]) %}
Review Comment:
i think you missed this one, but i don't think it's abused anywhere in here. let's merge this to alleviate CI pain and can fix in a follow-on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #11349: [ci] Use S3 for artifacts
Posted by GitBox <gi...@apache.org>.
areusch merged PR #11349:
URL: https://github.com/apache/tvm/pull/11349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #11349: [ci] Use S3 for artifacts
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #11349:
URL: https://github.com/apache/tvm/pull/11349#discussion_r876120066
##########
jenkins/macros.j2:
##########
@@ -89,3 +89,33 @@
}
},
{% endmacro %}
+
+{% macro upload_artifacts(tag, filenames, folders=[]) %}
Review Comment:
i think in Python we would avoid kwarg with an empty list initializer (e.g. `folders=None`), possible to do that here? i think that amounts to `for folder in (folders or [])`
##########
jenkins/macros.j2:
##########
@@ -89,3 +89,33 @@
}
},
{% endmacro %}
+
+{% macro upload_artifacts(tag, filenames, folders=[]) %}
Review Comment:
can we still print the the md5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org