You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/07/15 16:46:12 UTC
[GitHub] zeppelin pull request #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1193
[ZEPPELIN-1192] Block pyspark paragraph hang.
### What is this PR for?
This PR block pyspark paragraph hang.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1192
### How should this be tested?
1. build zeppelin without pyspark (just mvn clean package -DskipTests)
2. open note and set paragraph interpreter as "spark.pyspark"
3. hit "Ctrl+." for auto completion.
4. try run paragraph.
- please refer to the screenshot.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1192
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1193
----
commit 288eca7ddb8bffd271221ad21805f07d2181f8b5
Author: astroshim <hs...@nflabs.com>
Date: 2016-07-15T16:37:04Z
block infinite loop.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
\cc @bzz Ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
@bzz I rebased. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
\cc @bzz for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1193
@astroshim great! Small suggestion above. And what is with CI here? May be it's worth to `git rebase master` and force push?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1193
[ZEPPELIN-1192] Block pyspark paragraph hang.
### What is this PR for?
This PR block pyspark paragraph hang.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1192
### How should this be tested?
1. build zeppelin without pyspark (just mvn clean package -DskipTests)
2. open note and set paragraph interpreter as "spark.pyspark"
3. hit "Ctrl+." for auto completion.
4. try run paragraph.
- please refer to the screenshot.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1192
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1193
----
commit 288eca7ddb8bffd271221ad21805f07d2181f8b5
Author: astroshim <hs...@nflabs.com>
Date: 2016-07-15T16:37:04Z
block infinite loop.
commit 6eb1666dee0de4623b3874030cf50f4e13194b69
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-07T12:54:21Z
timeout value defines as a constant.
commit dbd649c00cad4cc3271674331774bba9caa37234
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-07T17:19:52Z
Merge branch 'master' of https://github.com/astroshim/zeppelin into ZEPPELIN-1192
commit e95f819ca02b85c9b55755af4981fc18d424848e
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-11T12:33:42Z
Merge branch 'master' into ZEPPELIN-1192
commit 670cbc85327119ae41e2837485110769cd34f331
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-11T12:54:08Z
log timing out.
commit 4b26ab36971b6ba44641fbab8eda94d48302ef4f
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-12T13:15:45Z
replace hardcoded value.
commit 9953b1add32d262a270ea92afe4aba30e12031f5
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-12T13:17:10Z
Merge branch 'master' into ZEPPELIN-1192
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
The reason of CI fails is..
```
Resolving deltas: 100% (13946/13946), completed with 385 local objects.
From https://github.com/apache/zeppelin
* branch refs/pull/1193/merge -> FETCH_HEAD
travis_time:end:16c30e18:start=1471009118100481571,finish=1471009120921906857,duration=2821425286
[0K$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout
[0Ktravis_fold:start:apt
[0K[33;1mAdding APT Sources (BETA)[0m
$ export DEBIAN_FRONTEND=noninteractive
travis_time:start:2224b420
[0K$ curl -sSL "http://keyserver.ubuntu.com/pks/lookup?op=get&search=0x51716619E084DAB9" | sudo -E apt-key add -
gpg: no valid OpenPGP data found.
travis_time:end:2224b420:start=1471009120981996375,finish=1471009141163566540,duration=20181570165
[0K
[31;1mThe command "curl -sSL "http://keyserver.ubuntu.com/pks/lookup?op=get&search=0x51716619E084DAB9" | sudo -E apt-key add -" failed and exited with 2 during .[0m
Your build has been stopped.
```
so I re-trigger CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1193
CI is still red :\ Could you please post here the reason?
Other than that, looks good to me, merging to master if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
please review this. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1193
Looks great to me, modulo the timeout logging issue noted about.
@astroshim plz ping when it's addressed and I'll be happy to merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
@bzz I added log and tested. Thank you for taking care of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1193
Thanks @astroshim ! CI is green now, merging to master if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---