You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/05 07:43:17 UTC
[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #367:
feat: remove extra code
xujianhai666 opened a new pull request #367: feat: remove extra code
URL: https://github.com/apache/rocketmq-client-go/pull/367
Closes #366
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] wenfengwang merged pull request #367: [ISSUE
#366] feat: remove extra code
Posted by GitBox <gi...@apache.org>.
wenfengwang merged pull request #367: [ISSUE #366] feat: remove extra code
URL: https://github.com/apache/rocketmq-client-go/pull/367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #367: [ISSUE
#366] feat: remove extra code
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #367: [ISSUE #366] feat: remove extra code
URL: https://github.com/apache/rocketmq-client-go/pull/367#issuecomment-570887680
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/367?src=pr&el=h1) Report
> Merging [#367](https://codecov.io/gh/apache/rocketmq-client-go/pull/367?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/7f7a35d4934dc7b52472fd19d1a3eedb5c73d911?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/367/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/367?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #367 +/- ##
==========================================
- Coverage 26.27% 26.19% -0.08%
==========================================
Files 47 47
Lines 5537 5531 -6
==========================================
- Hits 1455 1449 -6
Misses 3891 3891
Partials 191 191
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/367?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/367/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `50.26% <ø> (-0.53%)` | :arrow_down: |
| [internal/remote/future.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/367/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL2Z1dHVyZS5nbw==) | `100% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/367?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/367?src=pr&el=footer). Last update [7f7a35d...ca49153](https://codecov.io/gh/apache/rocketmq-client-go/pull/367?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services