You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/18 06:38:01 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
MaxGekk opened a new pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617
### What changes were proposed in this pull request?
1. Move TimeZoneUTC and TimeZoneGMT to DateTimeTestUtils
2. Remove TimeZoneGMT
3. Use ZoneId.systemDefault() instead of defaultTimeZone().toZoneId
4. Alias SQLDate & SQLTimestamp to internal types of DateType and TimestampType
### Why are the changes needed?
1. TimeZoneUTC and TimeZoneGMT are moved to DateTimeTestUtils because they are used only in tests
2. TimeZoneGMT can be removed because it is equal to TimeZoneUTC
3. After the PR #27494, Spark expressions and DateTimeUtils functions switched to ZoneId instead of TimeZone completely. `defaultTimeZone()` with `TimeZone` as return type is not needed anymore.
4. SQLDate and SQLTimestamp types can be explicitly aliased to internal types of DateType and and TimestampType instead of declaring this in a comment.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
By existing test suites
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590937127
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-596095615
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24247/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602570818
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120186/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-600366426
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602570818
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120186/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589543699
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602442690
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-605466883
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-612139691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25788/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601365160
**[Test build #120068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120068/testReport)** for PR 27617 at commit [`9d78a7d`](https://github.com/apache/spark/commit/9d78a7d37a970231654fce94263b1ebbe52cf658).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589894640
**[Test build #118804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118804/testReport)** for PR 27617 at commit [`cbf69fb`](https://github.com/apache/spark/commit/cbf69fb295aa6a5df4d8cc791dc3acf2f4badb4b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590448541
**[Test build #118866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118866/testReport)** for PR 27617 at commit [`6840291`](https://github.com/apache/spark/commit/6840291526b44fb1fe5a76e5debddfc29d7e9eb3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-603529085
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120280/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589543699
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597611379
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-592074113
This LGTM but can we hold it a little bit? Recently there is a discussion about date/timestamp parsing backward compatibility and we may touch some datetime code to fix it. I'd like to avoid potential conflicts and merge this refactor at the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590204498
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118853/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590306524
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23616/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589543732
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591298901
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591055288
**[Test build #118926 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118926/testReport)** for PR 27617 at commit [`6a41a3c`](https://github.com/apache/spark/commit/6a41a3cab5478cdd906ff02a177c80ce0a421fb5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class MakeDecimal(`
* `case class MultiplyInterval(`
* `case class DivideInterval(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589512791
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587334969
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-600245839
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597468834
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24384/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-612139679
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-596095615
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24247/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602421477
Build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602570808
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590187245
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23599/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601460246
**[Test build #120068 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120068/testReport)** for PR 27617 at commit [`9d78a7d`](https://github.com/apache/spark/commit/9d78a7d37a970231654fce94263b1ebbe52cf658).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591279473
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590190165
**[Test build #118853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118853/testReport)** for PR 27617 at commit [`6840291`](https://github.com/apache/spark/commit/6840291526b44fb1fe5a76e5debddfc29d7e9eb3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589516013
**[Test build #118759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118759/testReport)** for PR 27617 at commit [`c475f27`](https://github.com/apache/spark/commit/c475f271b24f8d9ef7bbbc0f93a238600d70a717).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614465755
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26038/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587331140
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598037828
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119699/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602409929
**[Test build #120179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120179/testReport)** for PR 27617 at commit [`8669e29`](https://github.com/apache/spark/commit/8669e294ac38592b41cc733b87c176151801b7a3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602408297
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24892/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-603529085
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120280/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-600366430
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119947/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-612240407
**[Test build #121098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121098/testReport)** for PR 27617 at commit [`3215948`](https://github.com/apache/spark/commit/32159484c0a27def8e9b03532047f8d942797743).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614318644
**[Test build #121336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121336/testReport)** for PR 27617 at commit [`77a780f`](https://github.com/apache/spark/commit/77a780ff42cb996851255019e946c5fa2c325e8a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class JavaUserDefinedScalar `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602407687
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590013634
cc: @viirya @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602421429
**[Test build #120179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120179/testReport)** for PR 27617 at commit [`8669e29`](https://github.com/apache/spark/commit/8669e294ac38592b41cc733b87c176151801b7a3).
* This patch **fails due to an unknown error code, -9**.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-596127101
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119518/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589543707
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118757/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601838431
I have rebased this on the recent master, and got pretty interesting error:
```
org.scalatest.exceptions.GeneratorDrivenPropertyCheckFailedException: DateTimeException was thrown during property evaluation. Message: Invalid date 'February 29' as '1000' is not a leap year Occurred when passed generated values ( )
```
in https://github.com/apache/spark/pull/27617#issuecomment-601824955
It seems https://github.com/apache/spark/blob/b27b3c91f113ec49ee87c877dac0a602849d76b1/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala#L369 generates a timestamp which can be represented as local date-time in Julian calendar but not in Proleptic Gregorian calendar, see the error message. /cc @cloud-fan @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
viirya commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590013835
> Move TimeZoneUTC and TimeZoneGMT to DateTimeTestUtils
Remove TimeZoneGMT
A bit confused. `TimeZoneGMT` was removed why it also moved to `DateTimeTestUtils`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601825039
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614318834
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-603365323
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24990/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590187060
**[Test build #118850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118850/testReport)** for PR 27617 at commit [`dde714b`](https://github.com/apache/spark/commit/dde714b2587c82b39ad725771aa0a06fec5fe641).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591297561
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614465110
**[Test build #121354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121354/testReport)** for PR 27617 at commit [`77a780f`](https://github.com/apache/spark/commit/77a780ff42cb996851255019e946c5fa2c325e8a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382414377
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -407,53 +398,53 @@ object DateTimeUtils {
}
}
- private def localTimestamp(microsec: SQLTimestamp, zoneId: ZoneId): LocalDateTime = {
+ private def localTimestamp(microsec: Long, zoneId: ZoneId): LocalDateTime = {
microsToInstant(microsec).atZone(zoneId).toLocalDateTime
}
/**
* Returns the hour value of a given timestamp value. The timestamp is expressed in microseconds.
*/
- def getHours(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
+ def getHours(microsec: Long, zoneId: ZoneId): Int = {
localTimestamp(microsec, zoneId).getHour
}
/**
* Returns the minute value of a given timestamp value. The timestamp is expressed in
* microseconds.
*/
- def getMinutes(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
+ def getMinutes(microsec: Long, zoneId: ZoneId): Int = {
localTimestamp(microsec, zoneId).getMinute
}
/**
* Returns the second value of a given timestamp value. The timestamp is expressed in
* microseconds.
*/
- def getSeconds(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
+ def getSeconds(microsec: Long, zoneId: ZoneId): Int = {
localTimestamp(microsec, zoneId).getSecond
}
/**
* Returns the seconds part and its fractional part with microseconds.
*/
- def getSecondsWithFraction(microsec: SQLTimestamp, zoneId: ZoneId): Decimal = {
+ def getSecondsWithFraction(microsec: Long, zoneId: ZoneId): Decimal = {
Decimal(getMicroseconds(microsec, zoneId), 8, 6)
}
/**
* Returns seconds, including fractional parts, multiplied by 1000. The timestamp
* is expressed in microseconds since the epoch.
*/
- def getMilliseconds(timestamp: SQLTimestamp, zoneId: ZoneId): Decimal = {
+ def getMilliseconds(timestamp: Long, zoneId: ZoneId): Decimal = {
Review comment:
shall we be consistent and use parameter name "microsec"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589894902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118804/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589820285
**[Test build #118804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118804/testReport)** for PR 27617 at commit [`cbf69fb`](https://github.com/apache/spark/commit/cbf69fb295aa6a5df4d8cc791dc3acf2f4badb4b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591421735
**[Test build #118959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118959/testReport)** for PR 27617 at commit [`86ccef1`](https://github.com/apache/spark/commit/86ccef1da832d25166c3bfd018f1df9b6af5b9ee).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590306522
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601460778
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120068/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598050914
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-600245846
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24670/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590047746
> A bit confused. TimeZoneGMT was removed why it also moved to DateTimeTestUtils?
@viirya I moved it to `DateTimeTestUtils` because it is used only in tests, and then I removed it because semantically it is equivalent to `TimeZoneUTC`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591292449
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591292449
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-604606804
**[Test build #120437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120437/testReport)** for PR 27617 at commit [`d7f343b`](https://github.com/apache/spark/commit/d7f343b0cdfda28f165d64dcd3d05b217dc498b0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597468829
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614602862
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121354/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-605466883
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601806176
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24821/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589512797
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23508/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601805410
**[Test build #120108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120108/testReport)** for PR 27617 at commit [`8669e29`](https://github.com/apache/spark/commit/8669e294ac38592b41cc733b87c176151801b7a3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602570808
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-603365269
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-604606804
**[Test build #120437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120437/testReport)** for PR 27617 at commit [`d7f343b`](https://github.com/apache/spark/commit/d7f343b0cdfda28f165d64dcd3d05b217dc498b0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r381958925
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -321,13 +315,13 @@ object DateTimeUtils {
}
}
- def instantToMicros(instant: Instant): Long = {
+ def instantToMicros(instant: Instant): SQLTimestamp = {
Review comment:
Ah, I see. What's the original reason to add this alias? Centainly, I feel this kind of cosmetic aliases make little benefit in this case. Any benefit at the cost of at the expense of code readability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589512485
**[Test build #118757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118757/testReport)** for PR 27617 at commit [`9ba2d3d`](https://github.com/apache/spark/commit/9ba2d3d4ceb8f7b863ef0887f4e2c879a4ef05d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r381945079
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -321,13 +315,13 @@ object DateTimeUtils {
}
}
- def instantToMicros(instant: Instant): Long = {
+ def instantToMicros(instant: Instant): SQLTimestamp = {
Review comment:
This looks not consistent to me. `instantToMicros` indicates it returns number of microseconds and using `Long` looks reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-595345024
@cloud-fan @HyukjinKwon Are we waiting for some particular PR merged to the master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597611379
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589512791
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589543736
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118759/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590936386
**[Test build #118926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118926/testReport)** for PR 27617 at commit [`6a41a3c`](https://github.com/apache/spark/commit/6a41a3cab5478cdd906ff02a177c80ce0a421fb5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587444785
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-600245846
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24670/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-600365709
**[Test build #119947 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119947/testReport)** for PR 27617 at commit [`e12ec28`](https://github.com/apache/spark/commit/e12ec282f11fa49f1cf5dbe99c526ef79b1b5806).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587444032
**[Test build #118623 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118623/testReport)** for PR 27617 at commit [`0b5711e`](https://github.com/apache/spark/commit/0b5711e0e332817f6cff28eeeef79ccffeaca304).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589516013
**[Test build #118759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118759/testReport)** for PR 27617 at commit [`c475f27`](https://github.com/apache/spark/commit/c475f271b24f8d9ef7bbbc0f93a238600d70a717).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382447050
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -407,53 +398,53 @@ object DateTimeUtils {
}
}
- private def localTimestamp(microsec: SQLTimestamp, zoneId: ZoneId): LocalDateTime = {
+ private def localTimestamp(microsec: Long, zoneId: ZoneId): LocalDateTime = {
microsToInstant(microsec).atZone(zoneId).toLocalDateTime
}
/**
* Returns the hour value of a given timestamp value. The timestamp is expressed in microseconds.
*/
- def getHours(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
+ def getHours(microsec: Long, zoneId: ZoneId): Int = {
localTimestamp(microsec, zoneId).getHour
}
/**
* Returns the minute value of a given timestamp value. The timestamp is expressed in
* microseconds.
*/
- def getMinutes(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
+ def getMinutes(microsec: Long, zoneId: ZoneId): Int = {
localTimestamp(microsec, zoneId).getMinute
}
/**
* Returns the second value of a given timestamp value. The timestamp is expressed in
* microseconds.
*/
- def getSeconds(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
+ def getSeconds(microsec: Long, zoneId: ZoneId): Int = {
localTimestamp(microsec, zoneId).getSecond
}
/**
* Returns the seconds part and its fractional part with microseconds.
*/
- def getSecondsWithFraction(microsec: SQLTimestamp, zoneId: ZoneId): Decimal = {
+ def getSecondsWithFraction(microsec: Long, zoneId: ZoneId): Decimal = {
Decimal(getMicroseconds(microsec, zoneId), 8, 6)
}
/**
* Returns seconds, including fractional parts, multiplied by 1000. The timestamp
* is expressed in microseconds since the epoch.
*/
- def getMilliseconds(timestamp: SQLTimestamp, zoneId: ZoneId): Decimal = {
+ def getMilliseconds(timestamp: Long, zoneId: ZoneId): Decimal = {
Review comment:
I would use `micros` to be consistent to functions names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591257216
@cloud-fan Please, have a look at this if you have time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614455756
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597488706
**[Test build #119658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119658/testReport)** for PR 27617 at commit [`1fd3aa2`](https://github.com/apache/spark/commit/1fd3aa22c81b7a55fc280c18b25b1904210238bc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590187245
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23599/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598030116
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614249405
**[Test build #121336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121336/testReport)** for PR 27617 at commit [`77a780f`](https://github.com/apache/spark/commit/77a780ff42cb996851255019e946c5fa2c325e8a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602442690
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587331018
**[Test build #118615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118615/testReport)** for PR 27617 at commit [`0b5711e`](https://github.com/apache/spark/commit/0b5711e0e332817f6cff28eeeef79ccffeaca304).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597489346
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24389/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590937142
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23674/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590449528
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118866/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-604735727
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589512485
**[Test build #118757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118757/testReport)** for PR 27617 at commit [`9ba2d3d`](https://github.com/apache/spark/commit/9ba2d3d4ceb8f7b863ef0887f4e2c879a4ef05d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-605435679
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-603365269
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587444793
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118623/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587331151
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118615/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-605466622
**[Test build #120528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120528/testReport)** for PR 27617 at commit [`3b23c52`](https://github.com/apache/spark/commit/3b23c5268eb720c8a67910198cb6cbd2fd5d860c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597489333
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382391444
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -321,13 +315,13 @@ object DateTimeUtils {
}
}
- def instantToMicros(instant: Instant): Long = {
+ def instantToMicros(instant: Instant): SQLTimestamp = {
Review comment:
Yea, the removal looks fine to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591279479
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23699/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598037696
**[Test build #119699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119699/testReport)** for PR 27617 at commit [`54c0fe9`](https://github.com/apache/spark/commit/54c0fe9f0c54d65e9eb7b46a17e7d6a1519f5e22).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597488706
**[Test build #119658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119658/testReport)** for PR 27617 at commit [`1fd3aa2`](https://github.com/apache/spark/commit/1fd3aa22c81b7a55fc280c18b25b1904210238bc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587337249
**[Test build #118623 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118623/testReport)** for PR 27617 at commit [`0b5711e`](https://github.com/apache/spark/commit/0b5711e0e332817f6cff28eeeef79ccffeaca304).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589655608
**[Test build #118768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118768/testReport)** for PR 27617 at commit [`c475f27`](https://github.com/apache/spark/commit/c475f271b24f8d9ef7bbbc0f93a238600d70a717).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591292381
**[Test build #118950 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118950/testReport)** for PR 27617 at commit [`86ccef1`](https://github.com/apache/spark/commit/86ccef1da832d25166c3bfd018f1df9b6af5b9ee).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591056023
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614602852
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597468467
**[Test build #119653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119653/testReport)** for PR 27617 at commit [`1fd3aa2`](https://github.com/apache/spark/commit/1fd3aa22c81b7a55fc280c18b25b1904210238bc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598166525
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119706/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-612139015
**[Test build #121098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121098/testReport)** for PR 27617 at commit [`3215948`](https://github.com/apache/spark/commit/32159484c0a27def8e9b03532047f8d942797743).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-596095495
**[Test build #119518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119518/testReport)** for PR 27617 at commit [`86ccef1`](https://github.com/apache/spark/commit/86ccef1da832d25166c3bfd018f1df9b6af5b9ee).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591422616
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590306522
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587303945
**[Test build #118615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118615/testReport)** for PR 27617 at commit [`0b5711e`](https://github.com/apache/spark/commit/0b5711e0e332817f6cff28eeeef79ccffeaca304).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r381958925
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -321,13 +315,13 @@ object DateTimeUtils {
}
}
- def instantToMicros(instant: Instant): Long = {
+ def instantToMicros(instant: Instant): SQLTimestamp = {
Review comment:
Ah, I see. What's the original reason to add this alias? Centainly, I feel this kind of cosmetic aliases make the code hard to read somewhat. Any benefit at the cost of at the expense of code readability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-604607663
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25145/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-600245839
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614412749
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26033/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601365671
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24785/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601460775
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614462088
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614412436
**[Test build #121349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121349/testReport)** for PR 27617 at commit [`77a780f`](https://github.com/apache/spark/commit/77a780ff42cb996851255019e946c5fa2c325e8a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-612139679
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598032023
**[Test build #119699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119699/testReport)** for PR 27617 at commit [`54c0fe9`](https://github.com/apache/spark/commit/54c0fe9f0c54d65e9eb7b46a17e7d6a1519f5e22).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591278980
**[Test build #118950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118950/testReport)** for PR 27617 at commit [`86ccef1`](https://github.com/apache/spark/commit/86ccef1da832d25166c3bfd018f1df9b6af5b9ee).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382413974
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -138,25 +129,25 @@ object DateTimeUtils {
* Converts the timestamp to milliseconds since epoch. In spark timestamp values have microseconds
* precision, so this conversion is lossy.
*/
- def toMillis(us: SQLTimestamp): Long = {
+ def toMillis(us: Long): Long = {
Review comment:
nit: shall we make the name clearer? `microsToMillis`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382446647
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -138,25 +129,25 @@ object DateTimeUtils {
* Converts the timestamp to milliseconds since epoch. In spark timestamp values have microseconds
* precision, so this conversion is lossy.
*/
- def toMillis(us: SQLTimestamp): Long = {
+ def toMillis(us: Long): Long = {
Review comment:
I renamed it in another PR already: https://github.com/apache/spark/pull/27618
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590190444
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23602/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614602862
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121354/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598166516
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614601960
**[Test build #121354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121354/testReport)** for PR 27617 at commit [`77a780f`](https://github.com/apache/spark/commit/77a780ff42cb996851255019e946c5fa2c325e8a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class JavaUserDefinedScalar `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587334437
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598030126
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24428/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r384305534
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -568,8 +563,8 @@ object DateTimeUtils {
* The result is rounded to 8 decimal places if `roundOff` is set to true.
*/
def monthsBetween(
- time1: SQLTimestamp,
- time2: SQLTimestamp,
+ time1: Long,
+ time2: Long,
Review comment:
`micros1/2`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614412746
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591292462
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118950/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601825039
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601825051
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120108/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382953704
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -407,137 +397,141 @@ object DateTimeUtils {
}
}
- private def localTimestamp(microsec: SQLTimestamp, zoneId: ZoneId): LocalDateTime = {
- microsToInstant(microsec).atZone(zoneId).toLocalDateTime
+ private def getLocalDateTime(micros: Long, zoneId: ZoneId): LocalDateTime = {
+ microsToInstant(micros).atZone(zoneId).toLocalDateTime
}
/**
* Returns the hour value of a given timestamp value. The timestamp is expressed in microseconds.
*/
- def getHours(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
- localTimestamp(microsec, zoneId).getHour
+ def getHours(micros: Long, zoneId: ZoneId): Int = {
+ getLocalDateTime(micros, zoneId).getHour
}
/**
* Returns the minute value of a given timestamp value. The timestamp is expressed in
- * microseconds.
+ * microseconds since the epoch.
*/
- def getMinutes(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
- localTimestamp(microsec, zoneId).getMinute
+ def getMinutes(micros: Long, zoneId: ZoneId): Int = {
+ getLocalDateTime(micros, zoneId).getMinute
}
/**
* Returns the second value of a given timestamp value. The timestamp is expressed in
- * microseconds.
+ * microseconds since the epoch.
*/
- def getSeconds(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
- localTimestamp(microsec, zoneId).getSecond
+ def getSeconds(micros: Long, zoneId: ZoneId): Int = {
+ getLocalDateTime(micros, zoneId).getSecond
}
/**
* Returns the seconds part and its fractional part with microseconds.
*/
- def getSecondsWithFraction(microsec: SQLTimestamp, zoneId: ZoneId): Decimal = {
- Decimal(getMicroseconds(microsec, zoneId), 8, 6)
+ def getSecondsWithFraction(micros: Long, zoneId: ZoneId): Decimal = {
+ Decimal(getMicroseconds(micros, zoneId), 8, 6)
}
/**
- * Returns seconds, including fractional parts, multiplied by 1000. The timestamp
- * is expressed in microseconds since the epoch.
+ * Returns local seconds, including fractional parts, multiplied by 1000.
Review comment:
Returns local milliseconds?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590306524
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23616/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591298913
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23707/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598166525
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119706/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587304327
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-600245409
**[Test build #119947 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119947/testReport)** for PR 27617 at commit [`e12ec28`](https://github.com/apache/spark/commit/e12ec282f11fa49f1cf5dbe99c526ef79b1b5806).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-612139015
**[Test build #121098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121098/testReport)** for PR 27617 at commit [`3215948`](https://github.com/apache/spark/commit/32159484c0a27def8e9b03532047f8d942797743).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602442699
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24899/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-605436469
**[Test build #120528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120528/testReport)** for PR 27617 at commit [`3b23c52`](https://github.com/apache/spark/commit/3b23c5268eb720c8a67910198cb6cbd2fd5d860c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-603528356
**[Test build #120280 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120280/testReport)** for PR 27617 at commit [`9ec98eb`](https://github.com/apache/spark/commit/9ec98eb9ad870f336d6e6626bdf190f65c024297).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382447999
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -407,53 +398,53 @@ object DateTimeUtils {
}
}
- private def localTimestamp(microsec: SQLTimestamp, zoneId: ZoneId): LocalDateTime = {
+ private def localTimestamp(microsec: Long, zoneId: ZoneId): LocalDateTime = {
microsToInstant(microsec).atZone(zoneId).toLocalDateTime
}
/**
* Returns the hour value of a given timestamp value. The timestamp is expressed in microseconds.
*/
- def getHours(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
+ def getHours(microsec: Long, zoneId: ZoneId): Int = {
localTimestamp(microsec, zoneId).getHour
}
/**
* Returns the minute value of a given timestamp value. The timestamp is expressed in
* microseconds.
*/
- def getMinutes(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
+ def getMinutes(microsec: Long, zoneId: ZoneId): Int = {
localTimestamp(microsec, zoneId).getMinute
}
/**
* Returns the second value of a given timestamp value. The timestamp is expressed in
* microseconds.
*/
- def getSeconds(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
+ def getSeconds(microsec: Long, zoneId: ZoneId): Int = {
localTimestamp(microsec, zoneId).getSecond
}
/**
* Returns the seconds part and its fractional part with microseconds.
*/
- def getSecondsWithFraction(microsec: SQLTimestamp, zoneId: ZoneId): Decimal = {
+ def getSecondsWithFraction(microsec: Long, zoneId: ZoneId): Decimal = {
Decimal(getMicroseconds(microsec, zoneId), 8, 6)
}
/**
* Returns seconds, including fractional parts, multiplied by 1000. The timestamp
* is expressed in microseconds since the epoch.
*/
- def getMilliseconds(timestamp: SQLTimestamp, zoneId: ZoneId): Decimal = {
+ def getMilliseconds(timestamp: Long, zoneId: ZoneId): Decimal = {
Review comment:
And I am going to rename `date` to `days` when a parameter represents number of days since the epoch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591422616
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589820788
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23554/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-605436469
**[Test build #120528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120528/testReport)** for PR 27617 at commit [`3b23c52`](https://github.com/apache/spark/commit/3b23c5268eb720c8a67910198cb6cbd2fd5d860c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589820770
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-596094844
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382986084
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -407,137 +397,141 @@ object DateTimeUtils {
}
}
- private def localTimestamp(microsec: SQLTimestamp, zoneId: ZoneId): LocalDateTime = {
- microsToInstant(microsec).atZone(zoneId).toLocalDateTime
+ private def getLocalDateTime(micros: Long, zoneId: ZoneId): LocalDateTime = {
+ microsToInstant(micros).atZone(zoneId).toLocalDateTime
}
/**
* Returns the hour value of a given timestamp value. The timestamp is expressed in microseconds.
*/
- def getHours(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
- localTimestamp(microsec, zoneId).getHour
+ def getHours(micros: Long, zoneId: ZoneId): Int = {
+ getLocalDateTime(micros, zoneId).getHour
}
/**
* Returns the minute value of a given timestamp value. The timestamp is expressed in
- * microseconds.
+ * microseconds since the epoch.
*/
- def getMinutes(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
- localTimestamp(microsec, zoneId).getMinute
+ def getMinutes(micros: Long, zoneId: ZoneId): Int = {
+ getLocalDateTime(micros, zoneId).getMinute
}
/**
* Returns the second value of a given timestamp value. The timestamp is expressed in
- * microseconds.
+ * microseconds since the epoch.
*/
- def getSeconds(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
- localTimestamp(microsec, zoneId).getSecond
+ def getSeconds(micros: Long, zoneId: ZoneId): Int = {
+ getLocalDateTime(micros, zoneId).getSecond
}
/**
* Returns the seconds part and its fractional part with microseconds.
*/
- def getSecondsWithFraction(microsec: SQLTimestamp, zoneId: ZoneId): Decimal = {
- Decimal(getMicroseconds(microsec, zoneId), 8, 6)
+ def getSecondsWithFraction(micros: Long, zoneId: ZoneId): Decimal = {
+ Decimal(getMicroseconds(micros, zoneId), 8, 6)
}
/**
- * Returns seconds, including fractional parts, multiplied by 1000. The timestamp
- * is expressed in microseconds since the epoch.
+ * Returns local seconds, including fractional parts, multiplied by 1000.
+ *
+ * @param micros The number of microseconds since the epoch.
+ * @param zoneId The time zone id which milliseconds should be obtained in.
*/
- def getMilliseconds(timestamp: SQLTimestamp, zoneId: ZoneId): Decimal = {
- Decimal(getMicroseconds(timestamp, zoneId), 8, 3)
+ def getMilliseconds(micros: Long, zoneId: ZoneId): Decimal = {
+ Decimal(getMicroseconds(micros, zoneId), 8, 3)
}
/**
- * Returns seconds, including fractional parts, multiplied by 1000000. The timestamp
- * is expressed in microseconds since the epoch.
+ * Returns local seconds, including fractional parts, multiplied by 1000000.
Review comment:
It is not just local microseconds. For example, `2020-02-23 12:10:30.123456 Europe/Moscow`. The local microsecond part is `456`, but the function returns `30123456`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597489346
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24389/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601365660
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590305901
**[Test build #118866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118866/testReport)** for PR 27617 at commit [`6840291`](https://github.com/apache/spark/commit/6840291526b44fb1fe5a76e5debddfc29d7e9eb3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589820770
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590204487
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-605435679
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601806165
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598049755
**[Test build #119706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119706/testReport)** for PR 27617 at commit [`54c0fe9`](https://github.com/apache/spark/commit/54c0fe9f0c54d65e9eb7b46a17e7d6a1519f5e22).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602408288
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597476410
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119653/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-604607650
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382414618
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala
##########
@@ -144,7 +144,7 @@ class LegacyFastTimestampFormatter(
cal.getTimeInMillis * MICROS_PER_MILLIS + micros
}
- def format(timestamp: SQLTimestamp): String = {
+ def format(timestamp: Long): String = {
Review comment:
`microsec`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-603365323
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24990/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591298901
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597476336
**[Test build #119653 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119653/testReport)** for PR 27617 at commit [`1fd3aa2`](https://github.com/apache/spark/commit/1fd3aa22c81b7a55fc280c18b25b1904210238bc).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597611389
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119658/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591298344
**[Test build #118959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118959/testReport)** for PR 27617 at commit [`86ccef1`](https://github.com/apache/spark/commit/86ccef1da832d25166c3bfd018f1df9b6af5b9ee).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598050921
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24435/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-605466885
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120528/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589516320
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382986162
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -407,137 +397,141 @@ object DateTimeUtils {
}
}
- private def localTimestamp(microsec: SQLTimestamp, zoneId: ZoneId): LocalDateTime = {
- microsToInstant(microsec).atZone(zoneId).toLocalDateTime
+ private def getLocalDateTime(micros: Long, zoneId: ZoneId): LocalDateTime = {
+ microsToInstant(micros).atZone(zoneId).toLocalDateTime
}
/**
* Returns the hour value of a given timestamp value. The timestamp is expressed in microseconds.
*/
- def getHours(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
- localTimestamp(microsec, zoneId).getHour
+ def getHours(micros: Long, zoneId: ZoneId): Int = {
+ getLocalDateTime(micros, zoneId).getHour
}
/**
* Returns the minute value of a given timestamp value. The timestamp is expressed in
- * microseconds.
+ * microseconds since the epoch.
*/
- def getMinutes(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
- localTimestamp(microsec, zoneId).getMinute
+ def getMinutes(micros: Long, zoneId: ZoneId): Int = {
+ getLocalDateTime(micros, zoneId).getMinute
}
/**
* Returns the second value of a given timestamp value. The timestamp is expressed in
- * microseconds.
+ * microseconds since the epoch.
*/
- def getSeconds(microsec: SQLTimestamp, zoneId: ZoneId): Int = {
- localTimestamp(microsec, zoneId).getSecond
+ def getSeconds(micros: Long, zoneId: ZoneId): Int = {
+ getLocalDateTime(micros, zoneId).getSecond
}
/**
* Returns the seconds part and its fractional part with microseconds.
*/
- def getSecondsWithFraction(microsec: SQLTimestamp, zoneId: ZoneId): Decimal = {
- Decimal(getMicroseconds(microsec, zoneId), 8, 6)
+ def getSecondsWithFraction(micros: Long, zoneId: ZoneId): Decimal = {
+ Decimal(getMicroseconds(micros, zoneId), 8, 6)
}
/**
- * Returns seconds, including fractional parts, multiplied by 1000. The timestamp
- * is expressed in microseconds since the epoch.
+ * Returns local seconds, including fractional parts, multiplied by 1000.
Review comment:
See the example above, the function returns `30123` instead of the milliseconds field `123`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-605466885
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120528/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382986200
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala
##########
@@ -144,7 +144,7 @@ class LegacyFastTimestampFormatter(
cal.getTimeInMillis * MICROS_PER_MILLIS + micros
}
- def format(timestamp: SQLTimestamp): String = {
+ def format(timestamp: Long): String = {
Review comment:
Renamed to `micros` for consistency with other places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590305901
**[Test build #118866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118866/testReport)** for PR 27617 at commit [`6840291`](https://github.com/apache/spark/commit/6840291526b44fb1fe5a76e5debddfc29d7e9eb3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591056034
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118926/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614250203
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614250219
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26019/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590936386
**[Test build #118926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118926/testReport)** for PR 27617 at commit [`6a41a3c`](https://github.com/apache/spark/commit/6a41a3cab5478cdd906ff02a177c80ce0a421fb5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591056034
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118926/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591292462
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118950/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r384303769
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -39,84 +39,75 @@ import org.apache.spark.unsafe.types.{CalendarInterval, UTF8String}
*/
object DateTimeUtils {
- // we use Int and Long internally to represent [[DateType]] and [[TimestampType]]
- type SQLDate = Int
- type SQLTimestamp = Long
-
// see http://stackoverflow.com/questions/466321/convert-unix-timestamp-to-julian
// it's 2440587.5, rounding up to compatible with Hive
final val JULIAN_DAY_OF_EPOCH = 2440588
- final val TimeZoneGMT = TimeZone.getTimeZone("GMT")
- final val TimeZoneUTC = TimeZone.getTimeZone("UTC")
-
val TIMEZONE_OPTION = "timeZone"
- def defaultTimeZone(): TimeZone = TimeZone.getDefault()
-
def getZoneId(timeZoneId: String): ZoneId = ZoneId.of(timeZoneId, ZoneId.SHORT_IDS)
def getTimeZone(timeZoneId: String): TimeZone = {
TimeZone.getTimeZone(getZoneId(timeZoneId))
}
- def microsToDays(timestamp: SQLTimestamp): SQLDate = {
- microsToDays(timestamp, defaultTimeZone().toZoneId)
+ def microsToDays(timestamp: Long): Int = {
+ microsToDays(timestamp, ZoneId.systemDefault())
}
- def microsToDays(timestamp: SQLTimestamp, zoneId: ZoneId): SQLDate = {
+ def microsToDays(timestamp: Long, zoneId: ZoneId): Int = {
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589512797
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23508/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-603529073
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601365660
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590188366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118850/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598037819
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589543559
**[Test build #118757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118757/testReport)** for PR 27617 at commit [`9ba2d3d`](https://github.com/apache/spark/commit/9ba2d3d4ceb8f7b863ef0887f4e2c879a4ef05d4).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589820788
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23554/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-604735732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120437/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590204498
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118853/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587304335
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23368/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598048390
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587304335
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23368/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-603529073
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-612240904
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602421484
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120179/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614318834
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589543736
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118759/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597486134
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r381945613
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -321,13 +315,13 @@ object DateTimeUtils {
}
}
- def instantToMicros(instant: Instant): Long = {
+ def instantToMicros(instant: Instant): SQLTimestamp = {
Review comment:
Examples: `def localDateToDays(localDate: LocalDate): Int`, `def daysToLocalDate(days: Int): LocalDate`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-604607650
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-604607663
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25145/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-598032023
**[Test build #119699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119699/testReport)** for PR 27617 at commit [`54c0fe9`](https://github.com/apache/spark/commit/54c0fe9f0c54d65e9eb7b46a17e7d6a1519f5e22).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597476401
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590187242
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587304327
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589894899
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589550112
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r381946103
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -321,13 +315,13 @@ object DateTimeUtils {
}
}
- def instantToMicros(instant: Instant): Long = {
+ def instantToMicros(instant: Instant): SQLTimestamp = {
Review comment:
BTW I don't like the type alias `SQLTimestamp` and `SQLDate`. It just costs me more time when reading code. Also cc @HyukjinKwon @viirya @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597476401
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-596127098
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589543707
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118757/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r381852391
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -39,29 +39,23 @@ import org.apache.spark.unsafe.types.{CalendarInterval, UTF8String}
*/
object DateTimeUtils {
- // we use Int and Long internally to represent [[DateType]] and [[TimestampType]]
- type SQLDate = Int
- type SQLTimestamp = Long
+ type SQLDate = DateType.InternalType
+ type SQLTimestamp = TimestampType.InternalType
// see http://stackoverflow.com/questions/466321/convert-unix-timestamp-to-julian
// it's 2440587.5, rounding up to compatible with Hive
final val JULIAN_DAY_OF_EPOCH = 2440588
- final val TimeZoneGMT = TimeZone.getTimeZone("GMT")
- final val TimeZoneUTC = TimeZone.getTimeZone("UTC")
-
val TIMEZONE_OPTION = "timeZone"
- def defaultTimeZone(): TimeZone = TimeZone.getDefault()
-
def getZoneId(timeZoneId: String): ZoneId = ZoneId.of(timeZoneId, ZoneId.SHORT_IDS)
def getTimeZone(timeZoneId: String): TimeZone = {
TimeZone.getTimeZone(getZoneId(timeZoneId))
}
// we should use the exact day as Int, for example, (year, month, day) -> day
def millisToDays(millisUtc: Long): SQLDate = {
- millisToDays(millisUtc, defaultTimeZone().toZoneId)
+ millisToDays(millisUtc, ZoneId.systemDefault())
Review comment:
An user can change the system time zone. If we make it as a constant, the function will not respect to new settings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-587444785
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589656641
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-590204442
**[Test build #118853 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118853/testReport)** for PR 27617 at commit [`6840291`](https://github.com/apache/spark/commit/6840291526b44fb1fe5a76e5debddfc29d7e9eb3).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614412746
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591056023
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-603364022
**[Test build #120280 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120280/testReport)** for PR 27617 at commit [`9ec98eb`](https://github.com/apache/spark/commit/9ec98eb9ad870f336d6e6626bdf190f65c024297).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602569699
**[Test build #120186 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120186/testReport)** for PR 27617 at commit [`aa8a62f`](https://github.com/apache/spark/commit/aa8a62f474acf05f82f311981c4e2d3dcad353cf).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `final class VarianceThresholdSelector @Since(\"3.1.0\")(@Since(\"3.1.0\") override val uid: String)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-612240908
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121098/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-596095611
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-589516325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23510/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602421477
Build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591279473
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591298344
**[Test build #118959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118959/testReport)** for PR 27617 at commit [`86ccef1`](https://github.com/apache/spark/commit/86ccef1da832d25166c3bfd018f1df9b6af5b9ee).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614465750
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-591956082
@cloud-fan It is ready, please, take a look at it when you have time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-602442129
**[Test build #120186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120186/testReport)** for PR 27617 at commit [`aa8a62f`](https://github.com/apache/spark/commit/aa8a62f474acf05f82f311981c4e2d3dcad353cf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-601805410
**[Test build #120108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120108/testReport)** for PR 27617 at commit [`8669e29`](https://github.com/apache/spark/commit/8669e294ac38592b41cc733b87c176151801b7a3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27617:
[SPARK-30865][SQL] Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-612240904
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-614465110
**[Test build #121354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121354/testReport)** for PR 27617 at commit [`77a780f`](https://github.com/apache/spark/commit/77a780ff42cb996851255019e946c5fa2c325e8a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#issuecomment-597610349
**[Test build #119658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119658/testReport)** for PR 27617 at commit [`1fd3aa2`](https://github.com/apache/spark/commit/1fd3aa22c81b7a55fc280c18b25b1904210238bc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org