You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/08/23 11:30:52 UTC
[GitHub] [incubator-pekko-http] mdedetrich opened a new pull request, #305: Use c.abort in macro error cases
mdedetrich opened a new pull request, #305:
URL: https://github.com/apache/incubator-pekko-http/pull/305
I started working on macros recently and when browsing through pekko-http I noticed that we are throwing exceptions rather than `c.abort` which is what you are intended to use in unhandled macro cases (`c.abort` contains information about macro expansion such as the current macro position which is helpful for the error message).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin commented on pull request #305: Use c.abort in macro error cases
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #305:
URL: https://github.com/apache/incubator-pekko-http/pull/305#issuecomment-1689849422
I know little about macro but Great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich merged pull request #305: Use c.abort in macro error cases
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #305:
URL: https://github.com/apache/incubator-pekko-http/pull/305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org