[GitHub] [flink] matriv commented on a change in pull request #19045: [FLINK-26194][table-api] Deprecate unused options from TableConfig

[GitBox <gi...@apache.org>]

matriv commented on a change in pull request #19045:
URL: https://github.com/apache/flink/pull/19045#discussion_r827896265



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala
##########
@@ -945,12 +913,8 @@ object ScalarOperatorGens {
     val rule = CastRuleProvider.resolve(operand.resultType, targetType)
     rule match {
       case codeGeneratorCastRule: CodeGeneratorCastRule[_, _] =>
-        // Make sure to force nullability checks in case ctx.nullCheck is enabled
-        val inputType = if (ctx.nullCheck) {
-          operand.resultType.copy(true)
-        } else {
-          operand.resultType
-        }
+        // Make sure to force nullability checks in case type is nullable

Review comment:
       leftover
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org