[jira] [Commented] (FELIX-5117) Call to SSOHttpSessionListener#sessionDestroyed is done after the session is invalidated

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-5117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026904#comment-15026904 ] 

ASF GitHub Bot commented on FELIX-5117:
---------------------------------------

GitHub user xfournet opened a pull request:

    https://github.com/apache/felix/pull/43

    FELIX-5117 call SSOHttpSessionListener#sessionDestroyed before the se…

    …ssion is invalidated

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xfournet/felix FELIX-5117

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/felix/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #43
    
----
commit 40f847ee2e2149174cec391b098be56988a9a226
Author: Xavier Fournet <xa...@gmail.com>
Date:   2015-11-25T14:35:31Z

    FELIX-5117 call SSOHttpSessionListener#sessionDestroyed before the session is invalidated

----


> Call to SSOHttpSessionListener#sessionDestroyed is done after the session is invalidated
> ----------------------------------------------------------------------------------------
>
>                 Key: FELIX-5117
>                 URL: https://issues.apache.org/jira/browse/FELIX-5117
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>    Affects Versions: http.base-3.0.0, http.base-3.0.2, http.jetty-3.1.0, http.jetty-3.1.2
>            Reporter: Xavier Fournet
>
> The javadoc of javax.servlet.http.HttpSessionListener#sessionDestroyed indicate that the method should called before the session is invalidated ("Receives notification that a session is about to be invalidated.").
> This was working correctly with HTTP Felix 2.x but no more working with HTTP Felix 3.1.x because the method is called after the session is invalidated, so any attempt to get information from the session in this method will throw an exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)