You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bigtop.apache.org by "Roman Shaposhnik (JIRA)" <ji...@apache.org> on 2012/06/24 22:59:42 UTC

[jira] [Commented] (BIGTOP-649) PackageTestCommon.checkRemoval() is broken

    [ https://issues.apache.org/jira/browse/BIGTOP-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400210#comment-13400210 ] 

Roman Shaposhnik commented on BIGTOP-649:
-----------------------------------------

+1 and thanks a million for the patch!
                
> PackageTestCommon.checkRemoval() is broken
> ------------------------------------------
>
>                 Key: BIGTOP-649
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-649
>             Project: Bigtop
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Andrew Bayer
>            Assignee: Andrew Bayer
>             Fix For: 0.4.0
>
>         Attachments: BIGTOP-649.diff.txt
>
>
> PackageTestCommon.checkRemoval() fails because there's no property on the class named "golden". However, there *is* such a property on TestPacakgesBasics, which inherits from PackageTestCommon, and checkRemoval() is, so far as I can tell, only called in one class, which itself extends TestPackagesBasics. So it makes sense, as I see it, to move checkRemoval() to TestPackagesBasics.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira