You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/20 19:02:00 UTC
[jira] [Commented] (NIFI-5068) Create a script to automate some of
RC verification
[ https://issues.apache.org/jira/browse/NIFI-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518496#comment-16518496 ]
ASF GitHub Bot commented on NIFI-5068:
--------------------------------------
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2806
NIFI-5068 [WIP] Script to automate RC validation
This is a work in process.
Currently this script will download and validate the hashes and signing, as well as unpack the zip.
Still need to:
- validate the commit
- run tests
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/nifi rc-check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2806.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2806
----
commit d7b41852f04d6d1d7027f95b11bf1eafb8d52282
Author: Otto Fowler <ot...@...>
Date: 2018-04-11T14:39:59Z
start of utility, though there is no download to test against
commit d0cd56cdba5ad3c8bf668068883a40193e51ffdc
Author: Otto Fowler <ot...@...>
Date: 2018-06-11T15:39:58Z
Merge branch 'master' of https://github.com/apache/nifi into rc-check
commit efad5da1557fba3f88bb3a8c45d64d523b674924
Author: Otto Fowler <ot...@...>
Date: 2018-06-14T19:58:51Z
some rework
commit 41995d5c57405cf10fe17d242dd75a1014b92f31
Author: Otto Fowler <ot...@...>
Date: 2018-06-14T20:19:04Z
works up until this point, but only with a release, need to have switch
commit 5081c1536d29b956abb1245a47a44629f9f784ea
Author: Otto Fowler <ot...@...>
Date: 2018-06-20T18:59:33Z
working for 1.7.0 rc
----
> Create a script to automate some of RC verification
> ---------------------------------------------------
>
> Key: NIFI-5068
> URL: https://issues.apache.org/jira/browse/NIFI-5068
> Project: Apache NiFi
> Issue Type: New Feature
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Major
>
> Similar to other projects, the download, signing and checksums of the rc materials can be verified by script and save everyone some trouble
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)