You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by gwax <gi...@git.apache.org> on 2015/04/13 21:25:48 UTC
[GitHub] thrift pull request: Replace deprecated "," with "as" in python ex...
GitHub user gwax opened a pull request:
https://github.com/apache/thrift/pull/440
Replace deprecated "," with "as" in python exception generation code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CloverHealth/thrift py3_fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #440
----
commit a704277d7df19463bbad7c2339cd9c194f44f9a8
Author: George Leslie-Waksman <ge...@cloverhealth.com>
Date: 2015-04-13T18:16:59Z
Replace deprecated "," with "as" in python except generation code.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1857 Replace deprecated "," with "as" ...
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/440#issuecomment-92498770
perfect, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1857 Replace deprecated "," with "as" ...
Posted by gwax <gi...@git.apache.org>.
Github user gwax commented on the pull request:
https://github.com/apache/thrift/pull/440#issuecomment-92496624
I have added the relevant (existing) Jira issue to the description. Is that sufficient or should I do something further?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Replace deprecated "," with "as" in python ex...
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/440#issuecomment-92490509
Hi @gwax, thanks for the patch. Can you please create a jira issue for this so we can better track your contribution. details available here: http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1857 Replace deprecated "," with "as" ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/440
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---