You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/01 13:45:29 UTC
[GitHub] [spark] taosiyuan163 opened a new pull request #34457: [SPARK-37178][ML] Add Target Encoding to ml.feature
taosiyuan163 opened a new pull request #34457:
URL: https://github.com/apache/spark/pull/34457
JIRA Issue: https://issues.apache.org/jira/browse/SPARK-37178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34457: [SPARK-37178][ML] Add Target Encoding to ml.feature
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34457:
URL: https://github.com/apache/spark/pull/34457#issuecomment-957021245
This appears to assume the target is 0/1. Target encoding is more general than that.
This would have to be implemented in Python as well at least, and have tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34457: [SPARK-37178][ML] Add Target Encoding to ml.feature
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34457:
URL: https://github.com/apache/spark/pull/34457#issuecomment-956247759
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] taosiyuan163 commented on pull request #34457: [SPARK-37178][ML] Add Target Encoding to ml.feature
Posted by GitBox <gi...@apache.org>.
taosiyuan163 commented on pull request #34457:
URL: https://github.com/apache/spark/pull/34457#issuecomment-957188475
> This appears to assume the target is 0/1. Target encoding is more general than that. This would have to be implemented in Python as well at least, and have tests.
Thanks for your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] taosiyuan163 commented on pull request #34457: [SPARK-37178][ML] Add Target Encoding to ml.feature
Posted by GitBox <gi...@apache.org>.
taosiyuan163 commented on pull request #34457:
URL: https://github.com/apache/spark/pull/34457#issuecomment-957188475
> This appears to assume the target is 0/1. Target encoding is more general than that. This would have to be implemented in Python as well at least, and have tests.
Thanks for your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #34457: [SPARK-37178][ML] Add Target Encoding to ml.feature
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #34457:
URL: https://github.com/apache/spark/pull/34457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] taosiyuan163 commented on pull request #34457: [SPARK-37178][ML] Add Target Encoding to ml.feature
Posted by GitBox <gi...@apache.org>.
taosiyuan163 commented on pull request #34457:
URL: https://github.com/apache/spark/pull/34457#issuecomment-957188475
> This appears to assume the target is 0/1. Target encoding is more general than that. This would have to be implemented in Python as well at least, and have tests.
Thanks for your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34457: [SPARK-37178][ML] Add Target Encoding to ml.feature
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34457:
URL: https://github.com/apache/spark/pull/34457#issuecomment-957021245
This appears to assume the target is 0/1. Target encoding is more general than that.
This would have to be implemented in Python as well at least, and have tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34457: [SPARK-37178][ML] Add Target Encoding to ml.feature
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34457:
URL: https://github.com/apache/spark/pull/34457#issuecomment-957021245
This appears to assume the target is 0/1. Target encoding is more general than that.
This would have to be implemented in Python as well at least, and have tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #34457: [SPARK-37178][ML] Add Target Encoding to ml.feature
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #34457:
URL: https://github.com/apache/spark/pull/34457#issuecomment-1035666556
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org