You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/12/21 22:44:54 UTC
[GitHub] couchdb-fauxton pull request: Configurable 'Generated: [date]' com...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/594
Configurable 'Generated: [date]' comments
A while back we added in a comment to the foot of the generated
index.html file containing a "Generated: [data]" text. This has
proven to be extremely useful.
This PR just expands on it a little to make the label itself
configurable. So for environments using different bundles of
the Fauxton code, it can output the build target name, plus
the generation date, e.g.
<!-- Env X. Generated: [date] -->
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton generation-label-comment-configurable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/594.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #594
----
commit 158c2083ae551967a745e31e9127be53c759ed8c
Author: Ben Keen <be...@gmail.com>
Date: 2015-12-21T21:44:22Z
Configurable 'Generated: [date]' comments
A while back we added in a comment to the foot of the generated
index.html file containing a "Generated: [data]" text. This has
proven to be extremely useful.
This PR just expands on it a little to make the label itself
configurable. So for environments using different bundles of
the Fauxton code, it can output the build target name, plus
the generation date, e.g.
<!-- Env X. Generated: [date] -->
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Configurable 'Generated: [date]' com...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Configurable 'Generated: [date]' com...
Posted by wohali <gi...@git.apache.org>.
Github user wohali commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/594#issuecomment-166443007
Looks good :) :wave: :+1: :maple_leaf:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Configurable 'Generated: [date]' com...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/594#issuecomment-166445943
Whoo, thanks @wohali! :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---