You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/04/19 20:25:49 UTC
Review Request: Fixed status udpate manager to ignore unexpected
acknowledgements.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10660/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/common/type_utils.hpp a7b55288cb2c105917357e6836421df2d9104cb0
src/slave/slave.cpp a84ef902bfabe6cb70bb7001e895f89fec0c694e
src/slave/status_update_manager.hpp 5584d40cc70cfc61512eac18ecb7d5d50268a51a
src/slave/status_update_manager.cpp 7b0949c74d2be8b3655cb72b0fbb480940fa3e75
src/tests/status_update_manager_tests.cpp 2f5426aed8110b758e68829090172dcb57f0b613
Diff: https://reviews.apache.org/r/10660/diff/
Testing
-------
make check
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*StatusUpdate*" --verbose --gtest_repeat=100 --gtest_break_on_failure
Thanks,
Vinod Kone
Re: Review Request: Fixed status udpate manager to ignore unexpected
acknowledgements.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10660/
-----------------------------------------------------------
(Updated April 19, 2013, 7:37 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. no need for review.
Description
-------
See summary.
Diffs (updated)
-----
src/common/type_utils.hpp a7b55288cb2c105917357e6836421df2d9104cb0
src/slave/slave.cpp a84ef902bfabe6cb70bb7001e895f89fec0c694e
src/slave/status_update_manager.hpp 5584d40cc70cfc61512eac18ecb7d5d50268a51a
src/slave/status_update_manager.cpp 7b0949c74d2be8b3655cb72b0fbb480940fa3e75
src/tests/status_update_manager_tests.cpp 2f5426aed8110b758e68829090172dcb57f0b613
Diff: https://reviews.apache.org/r/10660/diff/
Testing
-------
make check
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*StatusUpdate*" --verbose --gtest_repeat=100 --gtest_break_on_failure
Thanks,
Vinod Kone
Re: Review Request: Fixed status udpate manager to ignore unexpected
acknowledgements.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 19, 2013, 7:20 p.m., Ben Mahler wrote:
> > src/slave/status_update_manager.hpp, line 251
> > <https://reviews.apache.org/r/10660/diff/1/?file=282735#file282735line251>
> >
> > No need for toString(), can you do a sweep?
done
> On April 19, 2013, 7:20 p.m., Ben Mahler wrote:
> > src/tests/status_update_manager_tests.cpp, line 397
> > <https://reviews.apache.org/r/10660/diff/1/?file=282737#file282737line397>
> >
> > I'd love to see this assert killed in all our tests in favor of being inside MesosTest or MesosClusterTest.
agreed, lets do this one swell swoop later.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10660/#review19467
-----------------------------------------------------------
On April 19, 2013, 6:25 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10660/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 6:25 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/type_utils.hpp a7b55288cb2c105917357e6836421df2d9104cb0
> src/slave/slave.cpp a84ef902bfabe6cb70bb7001e895f89fec0c694e
> src/slave/status_update_manager.hpp 5584d40cc70cfc61512eac18ecb7d5d50268a51a
> src/slave/status_update_manager.cpp 7b0949c74d2be8b3655cb72b0fbb480940fa3e75
> src/tests/status_update_manager_tests.cpp 2f5426aed8110b758e68829090172dcb57f0b613
>
> Diff: https://reviews.apache.org/r/10660/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*StatusUpdate*" --verbose --gtest_repeat=100 --gtest_break_on_failure
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed status udpate manager to ignore unexpected
acknowledgements.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10660/#review19467
-----------------------------------------------------------
Ship it!
src/common/type_utils.hpp
<https://reviews.apache.org/r/10660/#comment40212>
No need for toString() which is now obviated by stringify anyway.
src/slave/slave.cpp
<https://reviews.apache.org/r/10660/#comment40215>
ditto
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/10660/#comment40217>
No need for toString(), can you do a sweep?
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/10660/#comment40216>
No need to stringify. Can you do a sweep?
src/tests/status_update_manager_tests.cpp
<https://reviews.apache.org/r/10660/#comment40221>
A comment as to how it tests this would be great! "This launches a task and induces lost ACK messages..."
src/tests/status_update_manager_tests.cpp
<https://reviews.apache.org/r/10660/#comment40218>
I'd love to see this assert killed in all our tests in favor of being inside MesosTest or MesosClusterTest.
- Ben Mahler
On April 19, 2013, 6:25 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10660/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 6:25 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/type_utils.hpp a7b55288cb2c105917357e6836421df2d9104cb0
> src/slave/slave.cpp a84ef902bfabe6cb70bb7001e895f89fec0c694e
> src/slave/status_update_manager.hpp 5584d40cc70cfc61512eac18ecb7d5d50268a51a
> src/slave/status_update_manager.cpp 7b0949c74d2be8b3655cb72b0fbb480940fa3e75
> src/tests/status_update_manager_tests.cpp 2f5426aed8110b758e68829090172dcb57f0b613
>
> Diff: https://reviews.apache.org/r/10660/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*StatusUpdate*" --verbose --gtest_repeat=100 --gtest_break_on_failure
>
>
> Thanks,
>
> Vinod Kone
>
>