You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/09/21 02:28:45 UTC

[GitHub] [couchdb-www] pas-trop-de-zele opened a new pull request #39: Change column style when resize using bootstrap

pas-trop-de-zele opened a new pull request #39:
URL: https://github.com/apache/couchdb-www/pull/39


   Hello there, I came across the website and here's are my proposed new layout look with the help of bootstrap
   
   
   Current: 2 column splitted into 2 section 3 and 3
   ![image](https://user-images.githubusercontent.com/67793141/134102336-f4d0ff58-fc54-4cc3-bd4c-2ada83223f4a.png)
   
   New: Combined both sections to get a more streamlined look
   ![2 columns](https://user-images.githubusercontent.com/67793141/134102455-b7908276-2cae-4e66-9c99-83c3eeae073c.JPG)
   
   -----------------------------------------------------------------------
   Current: 1 column left align
   ![image](https://user-images.githubusercontent.com/67793141/134102380-d4fd6e22-afb6-4797-ab99-5055abd485c4.png)
   New: Centered
   ![1 columns center](https://user-images.githubusercontent.com/67793141/134102532-0e59ba05-7ab3-47cd-afaf-719aba17b89d.JPG)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [couchdb-www] wohali commented on pull request #39: Change column style when resize using bootstrap

Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #39:
URL: https://github.com/apache/couchdb-www/pull/39#issuecomment-924440775


   HI there, thanks for the PR! Welcome to the CouchDB community.
   
   Does your solution work when all JS is disabled in the browser? The current website degrades gracefully with no JS support.
   
   I am also unconvinced that adding an entire framework (like Bootstrap) is the best way to accomplish something as simple as centre-ing.
   
   You should be able to achieve this with a pure CSS solution. If you can refactor to accomplish this without Bootstrap. we'll certainly consider the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [couchdb-www] pas-trop-de-zele commented on pull request #39: Change column style when resize using bootstrap

Posted by GitBox <gi...@apache.org>.
pas-trop-de-zele commented on pull request #39:
URL: https://github.com/apache/couchdb-www/pull/39#issuecomment-924447529


   Hi Joan, thank you for getting back!
   
   I believe it should work with JS disabled since I didn't included the JS script from bootstrap
   
   Having said that, I agree that bootstrap may have been overkill for it, I was mocking it up for that was the fastest way to go for me 😁
   
   I will refactor it with pure CSS and do another PR, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [couchdb-www] pas-trop-de-zele closed pull request #39: Change column style when resize using bootstrap

Posted by GitBox <gi...@apache.org>.
pas-trop-de-zele closed pull request #39:
URL: https://github.com/apache/couchdb-www/pull/39


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org