You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/08 03:45:56 UTC

[GitHub] [pulsar] RobertIndie opened a new pull request #14162: [Doc] Allow configuring `metadataStoreUrl` in `pulsar-perf managed-ledger`

RobertIndie opened a new pull request #14162:
URL: https://github.com/apache/pulsar/pull/14162


   
   Master Issue: #13760 
   
   ### Motivation
   
   Add doc for #14145 
   
   ### Documentation
   
   - [ ] `doc` 
     


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] RobertIndie commented on a change in pull request #14162: [Doc] Allow configuring `metadataStoreUrl` in `pulsar-perf managed-ledger`

Posted by GitBox <gi...@apache.org>.
RobertIndie commented on a change in pull request #14162:
URL: https://github.com/apache/pulsar/pull/14162#discussion_r803282646



##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -655,7 +655,7 @@ Options
 |`-time`, `--test-duration`|Test duration (in seconds). If this value is less than or equal to 0, it keeps publishing messages.|0|
 |`--threads`|Number of threads writing|1|
 |`-w`, `--write-quorum`|Ledger write quorum|1|
-|`-zk`, `--zookeeperServers`|ZooKeeper connection string||
+|`-md`, `--metadata-store`|Metadata store service url. eg: zk:my-zk:2181||

Review comment:
       Fixed. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14162: [Doc] Allow configuring `metadataStoreUrl` in `pulsar-perf managed-ledger`

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14162:
URL: https://github.com/apache/pulsar/pull/14162#issuecomment-1032184424


   @RobertIndie:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #14162: [Doc] Allow configuring `metadataStoreUrl` in `pulsar-perf managed-ledger`

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #14162:
URL: https://github.com/apache/pulsar/pull/14162#discussion_r801619802



##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -655,7 +655,7 @@ Options
 |`-time`, `--test-duration`|Test duration (in seconds). If this value is less than or equal to 0, it keeps publishing messages.|0|
 |`--threads`|Number of threads writing|1|
 |`-w`, `--write-quorum`|Ledger write quorum|1|
-|`-zk`, `--zookeeperServers`|ZooKeeper connection string||
+|`-md`, `--metadata-store`|Metadata store service url. eg: zk:my-zk:2181||

Review comment:
       same comment: https://github.com/apache/pulsar/pull/14145#discussion_r801605957




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet merged pull request #14162: [Doc] Allow configuring `metadataStoreUrl` in `pulsar-perf managed-ledger`

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #14162:
URL: https://github.com/apache/pulsar/pull/14162


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14162: [Doc] Allow configuring `metadataStoreUrl` in `pulsar-perf managed-ledger`

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14162:
URL: https://github.com/apache/pulsar/pull/14162#issuecomment-1032184730


   @RobertIndie:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org