You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vedantlodha (via GitHub)" <gi...@apache.org> on 2023/02/20 14:59:51 UTC
[GitHub] [airflow] vedantlodha opened a new pull request, #29639: Migrate breeze unit tests to pytest.
vedantlodha opened a new pull request, #29639:
URL: https://github.com/apache/airflow/pull/29639
As a part of #29305, this PR removes a unittest.TestCase dependency from breeze package. The only remaining unittest dependency of this unittest.mock which is anyways used by pytest-mock and is not in plans for removal according to https://github.com/apache/airflow/issues/29305#issuecomment-1435711841
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29639: Migrate breeze unit tests to pytest.
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29639:
URL: https://github.com/apache/airflow/pull/29639#issuecomment-1437270397
That's it? Are we done :)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29639: Migrate breeze unit tests to pytest.
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29639:
URL: https://github.com/apache/airflow/pull/29639#issuecomment-1437295426
Reopened :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vedantlodha commented on pull request #29639: Migrate breeze unit tests to pytest.
Posted by "vedantlodha (via GitHub)" <gi...@apache.org>.
vedantlodha commented on PR #29639:
URL: https://github.com/apache/airflow/pull/29639#issuecomment-1437272462
@potiuk Sorry! I see the issue was closed, but there are some tests in google providers that still use unittest. Working on a pr for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vedantlodha commented on pull request #29639: Migrate breeze unit tests to pytest.
Posted by "vedantlodha (via GitHub)" <gi...@apache.org>.
vedantlodha commented on PR #29639:
URL: https://github.com/apache/airflow/pull/29639#issuecomment-1437157482
@Taragolis Since youre the author of the issue, can you take a look into the pr (which is barey 2 lines of change :)) whenever you have some time? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29639: Migrate breeze unit tests to pytest.
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29639:
URL: https://github.com/apache/airflow/pull/29639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org