You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "qqu0127 (via GitHub)" <gi...@apache.org> on 2023/04/03 17:17:30 UTC
[GitHub] [helix] qqu0127 opened a new issue, #2430: WagedRebalancer should be better modularized
qqu0127 opened a new issue, #2430:
URL: https://github.com/apache/helix/issues/2430
**Is your feature request related to a problem? Please describe.**
https://github.com/apache/helix/blob/7e45947f3c2221c3dd9fa54d9668b2cf72c0cd8c/helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
is complicated. It contains multiple computation flows and threads --
1. Global rebalance
2. Partial rebalance
3. Emergency rebalance (main thread)
Ideally above constructs should be separated, but now they all all mixed together in one class.
As more and more features get into it, it's becoming less clear and hard to understand and manage complexity.
Put everything all in one class isn't a good pattern to begin with.
**Describe the solution you'd like**
We should modularize the class WagedRebalancer, by separating out components from it to standalone classes as possible.
**Additional context**
Add any other context or screenshots about the feature request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu closed issue #2430: WagedRebalancer should be better modularized
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu closed issue #2430: WagedRebalancer should be better modularized
URL: https://github.com/apache/helix/issues/2430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org