You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "wolf8334 (via GitHub)" <gi...@apache.org> on 2026/05/25 09:27:54 UTC
[PR] Operator docs: add description and example for StreamConverters.javaCollector [pekko]
wolf8334 opened a new pull request, #2992:
URL: https://github.com/apache/pekko/pull/2992
…ollector
Motivation:
The javaCollector operator doc page had a TODO placeholder instead of documentation.
Modification:
- Replace TODO with a Description section explaining how javaCollector works
- Add references to javaCollectorParallelUnordered and Sink.collect
- Add Scala and Java code examples using Collectors.toList
Result:
The StreamConverters.javaCollector operator docs are now complete.
Tests:
sbt "docs/Test/compile" -- passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Operator docs: add description and example for StreamConverters.javaCollector [pekko]
Posted by "wolf8334 (via GitHub)" <gi...@apache.org>.
wolf8334 commented on code in PR #2992:
URL: https://github.com/apache/pekko/pull/2992#discussion_r3297343855
##########
docs/src/test/java/jdocs/stream/operators/JavaCollectorDocExamples.java:
##########
@@ -0,0 +1,34 @@
+/*
Review Comment:
finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Operator docs: add description and example for StreamConverters.javaCollector [pekko]
Posted by "wolf8334 (via GitHub)" <gi...@apache.org>.
wolf8334 commented on PR #2992:
URL: https://github.com/apache/pekko/pull/2992#issuecomment-4533355319
Files are updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Operator docs: add description and example for StreamConverters.javaCollector [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #2992:
URL: https://github.com/apache/pekko/pull/2992#discussion_r3297271095
##########
docs/src/main/paradox/stream/operators/StreamConverters/javaCollector.md:
##########
@@ -11,4 +11,25 @@ Create a sink which materializes into a @scala[`Future`] @java[`CompletionStage`
## Description
-TODO: We would welcome help on contributing descriptions and examples, see: https://github.com/akka/akka/issues/25646
+`javaCollector` creates a @apidoc[Sink] that accepts a Java 8 @javadoc[java.util.stream.Collector](java.util.stream.Collector)
Review Comment:
can you remove the 8 from Java 8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Operator docs: add description and example for StreamConverters.javaCollector [pekko]
Posted by "wolf8334 (via GitHub)" <gi...@apache.org>.
wolf8334 commented on code in PR #2992:
URL: https://github.com/apache/pekko/pull/2992#discussion_r3297374041
##########
docs/src/test/scala/docs/stream/operators/JavaCollectorDocExample.scala:
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * license agreements; and to You under the Apache License, version 2.0:
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * This file is part of the Apache Pekko project, which was derived from Akka.
+ */
Review Comment:
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Operator docs: add description and example for StreamConverters.javaCollector [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #2992:
URL: https://github.com/apache/pekko/pull/2992#discussion_r3297282480
##########
docs/src/test/java/jdocs/stream/operators/JavaCollectorDocExamples.java:
##########
@@ -0,0 +1,34 @@
+/*
Review Comment:
the new files have the wrong license headers
https://github.com/apache/pekko/blob/main/CONTRIBUTING.md#pull-request-requirements
that page has a link to the right header for new files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Operator docs: add description and example for StreamConverters.javaCollector [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #2992:
URL: https://github.com/apache/pekko/pull/2992#discussion_r3297356026
##########
docs/src/test/java/jdocs/stream/operators/JavaCollectorDocExamples.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * license agreements; and to You under the Apache License, version 2.0:
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * This file is part of the Apache Pekko project, which was derived from Akka.
+ */
Review Comment:
use apache header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Operator docs: add description and example for StreamConverters.javaCollector [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #2992:
URL: https://github.com/apache/pekko/pull/2992#issuecomment-4533268885
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Operator docs: add description and example for StreamConverters.javaCollector [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #2992:
URL: https://github.com/apache/pekko/pull/2992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Operator docs: add description and example for StreamConverters.javaCollector [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #2992:
URL: https://github.com/apache/pekko/pull/2992#discussion_r3297357542
##########
docs/src/test/scala/docs/stream/operators/JavaCollectorDocExample.scala:
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * license agreements; and to You under the Apache License, version 2.0:
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * This file is part of the Apache Pekko project, which was derived from Akka.
+ */
Review Comment:
delete this and rerun `sbt headerCraete`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Operator docs: add description and example for StreamConverters.javaCollector [pekko]
Posted by "wolf8334 (via GitHub)" <gi...@apache.org>.
wolf8334 commented on code in PR #2992:
URL: https://github.com/apache/pekko/pull/2992#discussion_r3297296906
##########
docs/src/main/paradox/stream/operators/StreamConverters/javaCollector.md:
##########
@@ -11,4 +11,25 @@ Create a sink which materializes into a @scala[`Future`] @java[`CompletionStage`
## Description
-TODO: We would welcome help on contributing descriptions and examples, see: https://github.com/akka/akka/issues/25646
+`javaCollector` creates a @apidoc[Sink] that accepts a Java 8 @javadoc[java.util.stream.Collector](java.util.stream.Collector)
Review Comment:
finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org