You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/09 16:49:26 UTC

[GitHub] [flink] slinkydeveloper edited a comment on pull request #19025: [FLINK-26553][build] Configure scalafmt

slinkydeveloper edited a comment on pull request #19025:
URL: https://github.com/apache/flink/pull/19025#issuecomment-1063131040


   There is one pitfall to this PR. If you do `mvn checkstyle:apply` in a subdirectory project (e.g. `cd flink-scala && mvn spotless:apply`), it will fail cause it can't find the scalafmt conf. I don't have a good solution for this, except using `${rootDir}` (which will then won't allow users to do `mvn checkstyle:apply` anymore). See [this log](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=32763&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb) and [this commit](https://github.com/apache/flink/pull/19025/commits/c390847232844ab360f96483843daa52ef2262ff), where i disable spotless anyway as there's no need to run it at that phase, as it's done before during `mvn clean deploy`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org