Re: [PR] RATIS-2066. RaftServerProxy supports close callback [ratis]

["ChenSammi (via GitHub)" <gi...@apache.org>]

ChenSammi commented on PR #1072:
URL: https://github.com/apache/ratis/pull/1072#issuecomment-2093098293

   @szetszwo , notifyServerShutdown is not enough for this DN case. For DN, there is always new pipeline created and old pipeline destroyed.  I guess this notifyServerShutdown will be called when an old pipeline is closed.  This specific DN case, is when there is long GC, longer than configured threshold, RaftServerProxy will close itself. When this happens, we need to close DN as well. To achieve this, one solution is provide an close callback as this JIRA do, another solution is we start a new thread in DN to closely monitor the RaftServerProxy state, whether it's running or closed.  After some thoughts, I prefer the first solution since it will save a thread resource. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org