You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/17 01:13:50 UTC
[GitHub] [nifi] pvillard31 opened a new pull request #3768: NIFI-6717 - Add Job ID in attributes for PutBigQueryBatch
pvillard31 opened a new pull request #3768:
URL: https://github.com/apache/nifi/pull/3768
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #3768: NIFI-6717 - Add Job ID in attributes for PutBigQueryBatch
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3768:
URL: https://github.com/apache/nifi/pull/3768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #3768: NIFI-6717 - Add Job ID in attributes for PutBigQueryBatch
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #3768:
URL: https://github.com/apache/nifi/pull/3768#issuecomment-922256898
Thanks @exceptionfactory - fixed the unit test and added proper checks for the new attribute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #3768: NIFI-6717 - Add Job ID in attributes for PutBigQueryBatch
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #3768:
URL: https://github.com/apache/nifi/pull/3768#issuecomment-881791287
Re-opening to go with a set of pull requests related to BigQuery processors including #5227 and #5014.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #3768: NIFI-6717 - Add Job ID in attributes for PutBigQueryBatch
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #3768:
URL: https://github.com/apache/nifi/pull/3768#issuecomment-807194728
closing due to inactivity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt closed pull request #3768: NIFI-6717 - Add Job ID in attributes for PutBigQueryBatch
Posted by GitBox <gi...@apache.org>.
joewitt closed pull request #3768:
URL: https://github.com/apache/nifi/pull/3768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #3768: NIFI-6717 - Add Job ID in attributes for PutBigQueryBatch
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on pull request #3768:
URL: https://github.com/apache/nifi/pull/3768#issuecomment-914628513
@pvillard31 This seems like a helpful improvement, but the automated builds failed. Perhaps `job.getJobId()` returns `null` in the unit test? Either way, it would also be helpful to update one of the unit test methods to check for the presence of the new attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org