[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7149: Added Name in updateProject API and UI

["shwstppr (via GitHub)" <gi...@apache.org>]

shwstppr commented on code in PR #7149:
URL: https://github.com/apache/cloudstack/pull/7149#discussion_r1091698460


##########
server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:
##########
@@ -661,6 +661,11 @@ public void doInTransactionWithoutResult(TransactionStatus status) throws Resour
                     _projectDao.update(projectId, project);
                 }
 
+                if (name != null) {
+                    project.setName(name);
+                    _projectDao.update(projectId, project);
+                }
+

Review Comment:
   Don't think we need to update twice using Dao when both name and display text are being updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org