You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/02/09 17:27:40 UTC

Review Request 65589: Added comparison operators for operations.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65589/
-----------------------------------------------------------

Review request for mesos, Greg Mann and Jie Yu.


Bugs: MESOS-8382
    https://issues.apache.org/jira/browse/MESOS-8382


Repository: mesos


Description
-------

Added comparison operators for operations.


Diffs
-----

  include/mesos/type_utils.hpp af2b187b9b59552e4ba515ad640fd4419eaf5075 
  include/mesos/v1/mesos.hpp d4c354ab596a6ea361f2fe45afa46089f8c1a543 
  src/common/type_utils.cpp a4d5dcb4e4445e307356d9b0c16dd39f00f6a8e2 
  src/v1/mesos.cpp 8abeae06e0fa87b50933df1c222ad4724a0b0116 


Diff: https://reviews.apache.org/r/65589/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 65589: Added comparison operators for operations.

Posted by Greg Mann <gr...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65589/#review198666
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Feb. 9, 2018, 5:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65589/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2018, 5:27 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Bugs: MESOS-8382
>     https://issues.apache.org/jira/browse/MESOS-8382
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added comparison operators for operations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 2fff71fb4948b6ca2516582f9e623f0152a8cac8 
>   include/mesos/v1/mesos.hpp 15723a2377e57e88a6341b07a0e013a79e25d96d 
>   src/common/type_utils.cpp 3c2711be045600204d2961baa7e8690ff3db7ac7 
>   src/v1/mesos.cpp 1eb53f340393987ef7c390569728fd28fb81b0c4 
> 
> 
> Diff: https://reviews.apache.org/r/65589/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>