You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sumitagrawl (via GitHub)" <gi...@apache.org> on 2023/12/19 06:15:33 UTC
[PR] HDDS-9960. OM State machine lastIndexUpdate incorrect and complex [ozone]
sumitagrawl opened a new pull request, #5826:
URL: https://github.com/apache/ozone/pull/5826
## What changes were proposed in this pull request?
lastAppliedTransaction update can happen from two place `double buffer` and` ratis trigger notifyTermIndexUpdated`. This can impact update of lastApplied transaction higher than one from db transaction, and can impact
- replay of transaction may not be done
- update of last applied transaction wait for all coming in sequence
simplify updateLastAppliedIndex() call updated only using double buffer flush.
a. notifyTermIndexUpdated() should be updated using double buffer so that term index always in sync with db transaction info. This update is required for Leader state isReady() by ratis as present in comment.
b. doubleBuffer flush simplify update the transaction index as present in applyTransactionMap or ratisTransactionMap
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9960
## How was this patch tested?
- existing test case for impact of update last applied transaction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9960. OM State machine lastIndexUpdate consume memory and incorrect [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on PR #5826:
URL: https://github.com/apache/ozone/pull/5826#issuecomment-1865786909
The above changes impacting PrepareRequest, since its waiting for ratis commit index to be updated which follow same executorService to add to double buffer (to be in sequence) where PrepareRequest is blocking for commit index holding same thread of executorService. This cyclic dependency can not be handled with this solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9960. OM State machine lastIndexUpdate consume memory and incorrect [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl closed pull request #5826: HDDS-9960. OM State machine lastIndexUpdate consume memory and incorrect
URL: https://github.com/apache/ozone/pull/5826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org