You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/29 13:37:19 UTC
[GitHub] [maven] garydgregory opened a new pull request #474: [MNG-7164] Add constructor MojoExecutionException(Throwable).
garydgregory opened a new pull request #474:
URL: https://github.com/apache/maven/pull/474
Sometimes I have nothing additional to say in a message, I just want to propagate the Throwable.
See https://issues.apache.org/jira/browse/MNG-7164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #474: [MNG-7164] Add constructor MojoExecutionException(Throwable).
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #474:
URL: https://github.com/apache/maven/pull/474#issuecomment-926837839
Thanks Gary, will merge as soon as I can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] pzygielo commented on a change in pull request #474: [MNG-7164] Add constructor MojoExecutionException(Throwable).
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #474:
URL: https://github.com/apache/maven/pull/474#discussion_r641939849
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojoExecutionException.java
##########
@@ -41,6 +41,18 @@ public AbstractMojoExecutionException( String message, Throwable cause )
super( message, cause );
}
+ /**
+ * Construct a new <code>AbstractMojoExecutionException</code> exception wrapping an underlying <code>Throwable</code>.
+ *
+ * @param message
Review comment:
No such parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #474: [MNG-7164] Add constructor MojoExecutionException(Throwable).
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #474:
URL: https://github.com/apache/maven/pull/474#issuecomment-924843346
Would it make sense to also add a similar constructor to the `MojoFailureException` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #474: [MNG-7164] Add constructor MojoExecutionException(Throwable).
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #474:
URL: https://github.com/apache/maven/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #474: [MNG-7164] Add constructor MojoExecutionException(Throwable).
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #474:
URL: https://github.com/apache/maven/pull/474#issuecomment-924847808
>
>
> Would it make sense to also add a similar constructor to the `MojoFailureException` ?
Parity is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] garydgregory commented on a change in pull request #474: [MNG-7164] Add constructor MojoExecutionException(Throwable).
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #474:
URL: https://github.com/apache/maven/pull/474#discussion_r641940156
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojoExecutionException.java
##########
@@ -41,6 +41,18 @@ public AbstractMojoExecutionException( String message, Throwable cause )
super( message, cause );
}
+ /**
+ * Construct a new <code>AbstractMojoExecutionException</code> exception wrapping an underlying <code>Throwable</code>.
+ *
+ * @param message
Review comment:
TY @pzygielo , fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] garydgregory commented on a change in pull request #474: [MNG-7164] Add constructor MojoExecutionException(Throwable).
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #474:
URL: https://github.com/apache/maven/pull/474#discussion_r714325662
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/MojoExecutionException.java
##########
@@ -76,4 +76,16 @@ public MojoExecutionException( String message )
{
super( message );
}
+
+ /**
+ * Construct a new <code>MojoExecutionException</code> exception wrapping an underlying <code>Throwable</code>.
+ *
+ * @param cause
+ * @since 3.8.2
Review comment:
Done.
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojoExecutionException.java
##########
@@ -41,6 +41,17 @@ public AbstractMojoExecutionException( String message, Throwable cause )
super( message, cause );
}
+ /**
+ * Construct a new <code>AbstractMojoExecutionException</code> exception wrapping an underlying <code>Throwable</code>.
+ *
+ * @param cause
+ * @since 3.8.2
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] garydgregory commented on pull request #474: [MNG-7164] Add constructor MojoExecutionException(Throwable).
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #474:
URL: https://github.com/apache/maven/pull/474#issuecomment-925345568
> > Would it make sense to also add a similar constructor to the `MojoFailureException` ?
>
> Parity is good.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #474: [MNG-7164] Add constructor MojoExecutionException(Throwable).
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #474:
URL: https://github.com/apache/maven/pull/474#discussion_r713853530
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/MojoExecutionException.java
##########
@@ -76,4 +76,16 @@ public MojoExecutionException( String message )
{
super( message );
}
+
+ /**
+ * Construct a new <code>MojoExecutionException</code> exception wrapping an underlying <code>Throwable</code>.
+ *
+ * @param cause
+ * @since 3.8.2
Review comment:
3.8.3
##########
File path: maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojoExecutionException.java
##########
@@ -41,6 +41,17 @@ public AbstractMojoExecutionException( String message, Throwable cause )
super( message, cause );
}
+ /**
+ * Construct a new <code>AbstractMojoExecutionException</code> exception wrapping an underlying <code>Throwable</code>.
+ *
+ * @param cause
+ * @since 3.8.2
Review comment:
3.8.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org