You are viewing a plain text version of this content. The canonical link for it is here.

Posted to pluto-dev@portals.apache.org by "Neil Griffin (JIRA)" <ji...@apache.org> on 2018/01/20 16:27:00 UTC

[jira] [Commented] (PLUTO-683) TCK: Contesting tests that invoke a ResourceURL that was written to the response with BaseURL.write(Writer writer, boolean escapeXML) when passing escapeXML=true

    [ https://issues.apache.org/jira/browse/PLUTO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333252#comment-16333252 ] 

Neil Griffin commented on PLUTO-683:
------------------------------------

@[~vsingleton]: Issues like this were previously fixed under PLUTO-662. Please provide a fix similar to Git commits [18e2e6eab4ee49530fc64c5f185086858b344c47|https://github.com/apache/portals-pluto/commit/18e2e6eab4ee49530fc64c5f185086858b344c47] (only the friendly-url-routes.xml file) and [eba41878cf1c3bc8fe66188c9673176c2168c5a4|https://github.com/apache/portals-pluto/commit/eba41878cf1c3bc8fe66188c9673176c2168c5a4].

> TCK: Contesting tests that invoke a ResourceURL that was written to the response with BaseURL.write(Writer writer, boolean escapeXML) when passing escapeXML=true
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PLUTO-683
>                 URL: https://issues.apache.org/jira/browse/PLUTO-683
>             Project: Pluto
>          Issue Type: Bug
>          Components: tck
>    Affects Versions: 3.0.0
>            Reporter: Neil Griffin
>            Assignee: Vernon Singleton
>            Priority: Major
>             Fix For: 3.0.1
>
>
> The following tests attempt to invoke a ResourceURL that was written to the response with the {{BaseURL.write(Writer writer, boolean escapeXML)}} method when passing {{escapeXML=true}}:
>  * V2URLTests_BaseURL_ApiRenderResurl_writeB1
>  * V2URLTests_PortletURLGenerationListener_ApiRenderResurl_filterResourceURL3
> These tests pass on Pluto since it generates URLs that do not contain the ampersand (&) character. However, on Liferay Portal these tests fail since it generates URLs that use the ampersand character to separate URL name=value pairs. This results in URLs that look like the following:
> {noformat}
> http://localhost:8080/web/guest/v2urltests8
> ?p_p_id=URLTests_PortletURLGenerationListener_ApiRenderResurl_WAR_tckV2URLTests
> &amp;p_p_lifecycle=2
> &amp;p_p_state=normal
> &amp;p_p_mode=view
> &amp;p_p_cacheability=cacheLevelPage
> &amp;_URLTests_PortletURLGenerationListener_ApiRenderResurl_WAR_tckV2URLTests_tc=V2URLTests_PortletURLGenerationListener_ApiRenderResurl_filterResourceURL3
> &amp;_URLTests_PortletURLGenerationListener_ApiRenderResurl_WAR_tckV2URLTests_PUGL=Resource
> &amp;_URLTests_PortletURLGenerationListener_ApiRenderResurl_WAR_tckV2URLTests_PUGL2=Resource{noformat}
> Since the ampersand character is encoded as \{{&amp;}} the URL name=value pairs are not processed correctly by the underlying servlet container.
> The proposed solution is to add a Liferay "Friendly URL" to the WEB-INF/liferay-portlet.xml descriptor. This will only be enabled with the "liferay" profile is activated on the Maven command line. The friendly URL will be more not contain any ampersand characters.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)