You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "CapozXVII (via GitHub)" <gi...@apache.org> on 2023/09/05 15:36:24 UTC
[GitHub] [syncope] CapozXVII opened a new pull request, #513: WA: logoutType can now be set to services through console
CapozXVII opened a new pull request, #513:
URL: https://github.com/apache/syncope/pull/513
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on a diff in pull request #513: WA: logoutType can now be set to services through console
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on code in PR #513:
URL: https://github.com/apache/syncope/pull/513#discussion_r1316233310
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/clientapps/ClientAppDirectoryPanel.properties:
##########
@@ -66,3 +66,4 @@ compose.title=username attribute provider
usernameAttributeProviderConf.title=Username Attribute Provider for ${name}
ticketExpirationPolicy=Ticket Expiration Policy
auditHistory.title=Configuration history
+logoutType=Logout Type
Review Comment:
Please add the new key to all language files, not just default and `it`
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ClientAppDataBinderImpl.java:
##########
@@ -343,5 +343,6 @@ protected void copyToEntity(final ClientApp clientApp, final ClientAppTO clientA
}
clientApp.setProperties(clientAppTO.getProperties());
+ clientApp.setLogoutType(clientAppTO.getLogoutType());
Review Comment:
add the other way round to `copyToTO` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso merged pull request #513: SYNCOPE-1775: logoutType can now be set to CAS services
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso merged PR #513:
URL: https://github.com/apache/syncope/pull/513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on pull request #513: WA: logoutType can now be set to services through console
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on PR #513:
URL: https://github.com/apache/syncope/pull/513#issuecomment-1707071187
Thank you @CapozXVII
I think you need to do a couple of things, besides any eventual review of this PR:
1. submit your [ICLA](https://www.apache.org/licenses/contributor-agreements.html#clas) if you haven't before
1. open an improvement on [JIRA](https://issues.apache.org/jira/browse/SYNCOPE) for this work and then adjust this PR's title to contain the generated id `SYNCOPE-XXXX`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on pull request #513: SYNCOPE-1775: logoutType can now be set to CAS services
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso commented on PR #513:
URL: https://github.com/apache/syncope/pull/513#issuecomment-1707979568
Thank you very much @CapozXVII !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org