You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zmuxuny (via GitHub)" <gi...@apache.org> on 2026/10/10 16:34:36 UTC
[PR] fix(message): continue scans after unmatched pull batches [rocketmq-dashboard]
zmuxuny opened a new pull request, #6180:
URL: https://github.com/apache/rocketmq-dashboard/pull/6180
## Summary
Fixes #6177.
Continue topic-message and DLQ scans at the broker's next offset after `NO_MATCHED_MSG`. RocketMQ maps removed-message/empty filtered batches to this retry-immediately status even for wildcard pulls; it does not mean the queue is exhausted. Reset the consecutive illegal-offset counter after this valid advancing response.
The change retains non-advancing-offset termination, the topic pull-attempt budget, and the existing scan windows/result limits. It does not change truncation reporting (#5523) or stalled/illegal DLQ scan accounting (#4592).
## Validation
- Red: the two recovery regressions fail against unchanged production code (empty topic result; DLQ `NO_MESSAGES`). Independently reproduced by a reviewer.
- Green: `mvn -B -ntp -Dtest=RocketMQMessageProviderTest,RocketMQDLQProviderTest,MessageServiceTest,MessageControllerTest,DLQServiceTest,DLQControllerTest checkstyle:check test` — 214 tests passed, zero Checkstyle violations.
- Eight added tests cover recovery after empty batches, repeated-empty-batch limits, non-advancing offsets, and resetting the illegal-offset streak in both scanners.
- Independent review: 150 focused tests passed in a separate checkout.
No live broker or full MySQL-backed integration suite was run. GitHub CI is pending.
AI assistance was used for implementation and regression validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(message): continue scans after unmatched pull batches [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #6180:
URL: https://github.com/apache/rocketmq-dashboard/pull/6180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org