You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Wenpei <gi...@git.apache.org> on 2015/12/10 06:37:38 UTC
[GitHub] spark pull request: [SPARK] [API DOC] rdd's aggregate function
GitHub user Wenpei opened a pull request:
https://github.com/apache/spark/pull/10245
[SPARK] [API DOC] rdd's aggregate function
More accurate for RDD's aggregate function, especially for zeroValue parameter.
In old version, people may misunderstand and thought zeroValue may used in combine function only in aggregate api doc.
* Aggregate the elements of each partition, and then the results for all the partitions, using
* given combine functions and a neutral "zero value".
So I add more accurate explain for zeroValue in param part.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Wenpei/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10245.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10245
----
commit 3c620abdc549617e2e2fa269c08d8f686ab78c36
Author: Yu Wenpei <tu...@163.com>
Date: 2015-12-02T14:38:22Z
Merge pull request #1 from apache/master
updata 12.02
commit 45b0b5bda53c528a55450997199ab8e13a9f4e9a
Author: Yu Wenpei <tu...@163.com>
Date: 2015-12-03T15:11:43Z
Merge pull request #2 from apache/master
updata 12.03
commit 3d3fe6fd962133d74a4bed1192b652a77ab3add6
Author: Yu Wenpei <tu...@163.com>
Date: 2015-12-10T02:32:54Z
Merge pull request #3 from apache/master
dec 10 update
commit 38f8ac1c192aa1d39dd1fb5258547621b8133d3a
Author: Yu Wenpei <tu...@163.com>
Date: 2015-12-10T05:20:02Z
[SPARK API DOC] rdd's aggregate function
More accurate for RDD's aggregate function, especially for zeroValue parameter.
In old version, people may misunderstand and thought zeroValue may used in combine function only cause below
* Aggregate the elements of each partition, and then the results for all the partitions, using
* given combine functions and a neutral "zero value".
So I add more accurate explain for zeroValue in param part.
commit 28e199ccb37bc9e5d0cfa8979b1ec9a4edc865a2
Author: Yu Wenpei <tu...@163.com>
Date: 2015-12-10T05:22:55Z
[SPARK API DOC] rdd's aggregate function
Little change from conbOp to combOp
commit 653fd7c6f204fd172d162abd567687e7c0be2bee
Author: Yu Wenpei <tu...@163.com>
Date: 2015-12-10T05:27:29Z
Merge pull request #4 from apache/master
dec 10 update
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK] [API DOC] rdd's aggregate function
Posted by Wenpei <gi...@git.apache.org>.
Github user Wenpei commented on the pull request:
https://github.com/apache/spark/pull/10245#issuecomment-163863199
Should I cc someone to review it?
@liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK] [API DOC] rdd's aggregate function
Posted by Wenpei <gi...@git.apache.org>.
Github user Wenpei closed the pull request at:
https://github.com/apache/spark/pull/10245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK] [API DOC] rdd's aggregate function
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10245#issuecomment-163493188
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org