You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/13 15:20:21 UTC

[jira] [Commented] (FLINK-4028) AbstractAlignedProcessingTimeWindowOperator creates wrong TimeWindow

    [ https://issues.apache.org/jira/browse/FLINK-4028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327584#comment-15327584 ] 

ASF GitHub Bot commented on FLINK-4028:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/2097

    [FLINK-4028] Create correct TimeWindow in AbstractAlignedProcessingTimeWindowOperator

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink fix-aligned-time-window

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2097.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2097
    
----
commit 6180df6e11b7c27f62c9e25a1d7888c0b097674b
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-06-13T10:03:32Z

    [FLINK-4028] Create correct TimeWindow in AbstractAlignedProcessingTimeWindowOperator

----


> AbstractAlignedProcessingTimeWindowOperator creates wrong TimeWindow
> --------------------------------------------------------------------
>
>                 Key: FLINK-4028
>                 URL: https://issues.apache.org/jira/browse/FLINK-4028
>             Project: Flink
>          Issue Type: Bug
>          Components: Windowing Operators
>    Affects Versions: 1.0.0, 1.1.0, 1.0.1, 1.0.2, 1.0.3
>            Reporter: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.1.0
>
>
> In {{computeWindow}} we have this code: {{new TimeWindow(timestamp, timestamp + windowSize)}}. This is wrong because {{timestamp}} is actually the end timestamp of the window.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)