You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/26 06:02:59 UTC

[GitHub] [airflow] jhtimmins commented on a change in pull request #19121: Use fab models

jhtimmins commented on a change in pull request #19121:
URL: https://github.com/apache/airflow/pull/19121#discussion_r736178029



##########
File path: airflow/security/permissions.py
##########
@@ -35,8 +35,10 @@
 RESOURCE_MY_PASSWORD = "My Password"
 RESOURCE_MY_PROFILE = "My Profile"
 RESOURCE_PASSWORD = "Passwords"
-RESOURCE_PERMISSION = "Permissions"
-RESOURCE_PERMISSION_VIEW = "Permission Views"  # Refers to a Perm <-> View mapping, not an MVC View.
+RESOURCE_PERMISSION = "Permissions"  # TODO: Convert to Actions
+RESOURCE_PERMISSION_VIEW = (
+    "Permission Views"  # Refers to a Perm <-> View mapping, not an MVC View.   # TODO: Convert to Perms
+)

Review comment:
       Good catch




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org